Remove unused localized strings (microsoft#17486)

kimadeline · web-flow · commit b0e80c8071b7 · 2021-09-22T07:37:16.000-07:00
* Remove strings unused in the code

* Remove extra .ropeproject
diff --git a/package.nls.json b/package.nls.json
@@ -93,12 +93,8 @@
     "ExtensionChannels.downloadCompletedOutputMessage": "Insiders build download complete.",
     "ExtensionChannels.startingDownloadOutputMessage": "Starting download for Insiders build.",
     "Interpreters.environmentPromptMessage": "We noticed a new virtual environment has been created. Do you want to select it for the workspace folder?",
-    "Linter.enableLinter": "Enable {0}",
-    "Linter.enablePylint": "You have a pylintrc file in your workspace. Do you want to enable pylint?",
     "Linter.replaceWithSelectedLinter": "Multiple linters are enabled in settings. Replace with '{0}'?",
     "Linter.install": "Install a linter to get error reporting.",
-    "Linter.installPylint": "Install pylint",
-    "Linter.installFlake8": "Install flake8",
     "Linter.selectLinter": "Select Linter",
     "Installer.noCondaOrPipInstaller": "There is no Conda or Pip installer available in the selected environment.",
     "Installer.noPipInstaller": "There is no Pip installer available in the selected environment.",
diff --git a/package.nls.zh-cn.json b/package.nls.zh-cn.json
@@ -90,12 +90,8 @@
     "ExtensionChannels.downloadCompletedOutputMessage": "预览版下载完成。",
     "ExtensionChannels.startingDownloadOutputMessage": "开始下载预览版。",
     "Interpreters.environmentPromptMessage": "检测到新的虚拟环境，是否在此工作区中使用它？",
-    "Linter.enableLinter": "启用 {0}",
-    "Linter.enablePylint": "该工作区有一个 pylintrc 文件，是否启用 pylint？",
     "Linter.replaceWithSelectedLinter": "设置中启用了多个代码检查器，是否用 '{0}' 替换？",
     "Linter.install": "请安装一个代码检查器以获得错误报告。",
-    "Linter.installPylint": "安装 pylint",
-    "Linter.installFlake8": "安装 flake8",
     "Linter.selectLinter": "选择代码检查器",
     "Installer.noCondaOrPipInstaller": "所选环境中没有可用的 Conda 或 pip 安装器。",
     "Installer.noPipInstaller": "所选环境中没有可用的 pip 安装器。",
diff --git a/package.nls.zh-tw.json b/package.nls.zh-tw.json
@@ -54,8 +54,6 @@
     "ExtensionChannels.downloadCompletedOutputMessage": "Insiders 組建下載完成。",
     "ExtensionChannels.startingDownloadOutputMessage": "開始下載 Insiders 組建。",
     "Interpreters.environmentPromptMessage": "We noticed a new virtual environment has been created. Do you want to select it for the workspace folder?",
-    "Linter.enableLinter": "啟用 {0}",
-    "Linter.enablePylint": "您的工作區有 pylintrc 檔案。是否啟用 pylint?",
     "Linter.replaceWithSelectedLinter": "設定中啟用了多個 Linter。是否用 '{0}' 取代?",
     "Installer.noCondaOrPipInstaller": "選取環境中沒有可用的 Conda 或 Pip 安裝工具。",
     "Installer.noPipInstaller": "選取環境中沒有可用的 Pip 安裝工具。",
diff --git a/pythonFiles/.vscode/.ropeproject/config.py b/pythonFiles/.vscode/.ropeproject/config.py
diff --git a/pythonFiles/.vscode/.ropeproject/objectdb b/pythonFiles/.vscode/.ropeproject/objectdb
diff --git a/src/client/common/utils/localize.ts b/src/client/common/utils/localize.ts
@@ -352,19 +352,10 @@ export namespace Logging {
 }
 
 export namespace Linters {
-    export const enableLinter = localize('Linter.enableLinter', 'Enable {0}');
-    export const enablePylint = localize(
-        'Linter.enablePylint',
-        'You have a pylintrc file in your workspace. Do you want to enable pylint?',
-    );
     export const replaceWithSelectedLinter = localize(
         'Linter.replaceWithSelectedLinter',
         "Multiple linters are enabled in settings. Replace with '{0}'?",
     );
-
-    export const installMessage = localize('Linter.install', 'Install a linter to get error reporting.');
-    export const installPylint = localize('Linter.installPylint', 'Install pylint');
-    export const installFlake8 = localize('Linter.installFlake8', 'Install flake8');
     export const selectLinter = localize('Linter.selectLinter', 'Select Linter');
 }
 
diff --git a/src/test/common/installer/installer.unit.test.ts b/src/test/common/installer/installer.unit.test.ts
@@ -51,15 +51,13 @@ import {
 } from '../../../client/common/types';
 import { createDeferred, Deferred } from '../../../client/common/utils/async';
 import { getNamesAndValues } from '../../../client/common/utils/enum';
-import { Common, Linters } from '../../../client/common/utils/localize';
 import { IInterpreterService } from '../../../client/interpreter/contracts';
 import { ServiceContainer } from '../../../client/ioc/container';
 import { IServiceContainer } from '../../../client/ioc/types';
 import { LinterManager } from '../../../client/linters/linterManager';
 import { ILinterManager } from '../../../client/linters/types';
 import { PythonEnvironment } from '../../../client/pythonEnvironments/info';
 import { sleep } from '../../common';
-import { MockWorkspaceConfiguration } from '../../mocks/mockWorkspaceConfig';
 
 use(chaiAsPromised);
 
@@ -912,43 +910,5 @@ suite('Module Installer only', () => {
             expect(response).to.be.equal(InstallerResponse.Installed);
             assert.ok(install.calledOnceWith(product, resource, undefined));
         });
-
-        test('Do not show prompt if linter path is set', async () => {
-            when(workspaceService.getConfiguration('python')).thenReturn(
-                new MockWorkspaceConfiguration({
-                    'linting.pylintPath': {
-                        globalValue: 'path/to/something',
-                    },
-                }),
-            );
-            when(productService.getProductType(Product.pylint)).thenReturn(ProductType.Linter);
-            when(productPathService.getExecutableNameFromSettings(Product.pylint, resource)).thenReturn(
-                'path/to/something',
-            );
-            installer.isModuleExecutable = false;
-
-            const product = Product.pylint;
-            const options = ['Select Linter', 'Do not show again'];
-            const productName = ProductNames.get(product)!;
-            await installer.promptToInstallImplementation(product, resource);
-            verify(
-                appShell.showInformationMessage(
-                    Linters.installMessage(),
-                    Linters.installPylint(),
-                    Linters.installFlake8(),
-                    Common.doNotShowAgain(),
-                ),
-            ).never();
-            verify(
-                appShell.showErrorMessage(`Linter ${productName} is not installed.`, 'Install', options[0], options[1]),
-            ).never();
-            verify(
-                appShell.showErrorMessage(
-                    `Path to the ${productName} linter is invalid (path/to/something)`,
-                    options[0],
-                    options[1],
-                ),
-            ).once();
-        });
     });
 });
