Automl - minor bug fixes (GoogleCloudPlatform#1168)

nirupa-kumar · nnegrey · commit e60d73155f38 · 2018-08-01T11:10:44.000-07:00
* Test push

* Vision AutoML

* Vision AutoML updates + Translate AutoML

* Translate README fixes

* Fixing Kokoro failure issue

* Language AutoML

* Vision AutoML

* Translate AutoML files added

* Triggering tests

* Triggering tests

* Updates based on comments

* Updates after review comments

* Fixed build issue

* Fixed build issue

* Fix other bugs after review
* pom file updates
* region tag modification
* bucket name update for language
* other minor updates
diff --git a/language/automl/pom.xml b/language/automl/pom.xml
@@ -15,7 +15,7 @@
 -->
 <project>
   <modelVersion>4.0.0</modelVersion>
-  <groupId>com.example.vision</groupId>
+  <groupId>com.google.cloud.language.samples</groupId>
   <artifactId>language-automl</artifactId>
   <packaging>jar</packaging>
 
diff --git a/language/automl/src/main/java/com/google/cloud/language/samples/ModelApi.java b/language/automl/src/main/java/com/google/cloud/language/samples/ModelApi.java
@@ -131,14 +131,14 @@ public static void listModels(String projectId, String computeRegion, String fil
     LocationName projectLocation = LocationName.of(projectId, computeRegion);
 
     // Create list models request.
-    ListModelsRequest listModlesRequest =
+    ListModelsRequest listModelsRequest =
         ListModelsRequest.newBuilder()
             .setParent(projectLocation.toString())
             .setFilter(filter)
             .build();
 
     System.out.println("List of models:");
-    for (Model model : client.listModels(listModlesRequest).iterateAll()) {
+    for (Model model : client.listModels(listModelsRequest).iterateAll()) {
       // Display the model information.
       System.out.println(String.format("Model name: %s", model.getName()));
       System.out.println(
diff --git a/language/automl/src/test/java/com/google/cloud/language/samples/DatasetApiIT.java b/language/automl/src/test/java/com/google/cloud/language/samples/DatasetApiIT.java
@@ -34,7 +34,7 @@
 public class DatasetApiIT {
 
   private static final String PROJECT_ID = "java-docs-samples-testing";
-  private static final String BUCKET = PROJECT_ID + "-vcm";
+  private static final String BUCKET = PROJECT_ID + "-lcm";
   private static final String COMPUTE_REGION = "us-central1";
   private static final String DATASET_NAME = "test_language_dataset";
   private ByteArrayOutputStream bout;
diff --git a/translate/automl/pom.xml b/translate/automl/pom.xml
@@ -1,5 +1,5 @@
 <!--
-  Copyright 2016 Google Inc.
+  Copyright 2018 Google Inc.
 
   Licensed under the Apache License, Version 2.0 (the "License");
   you may not use this file except in compliance with the License.
diff --git a/translate/automl/src/main/java/com/google/cloud/translate/automl/DatasetApi.java b/translate/automl/src/main/java/com/google/cloud/translate/automl/DatasetApi.java
@@ -45,7 +45,7 @@
  */
 public class DatasetApi {
 
-  // [START automl_translate_create_dataset]
+  // [START automl_translation_create_dataset]
   /**
    * Demonstrates using the AutoML client to create a dataset
    *
diff --git a/translate/automl/src/test/java/com/google/cloud/translate/automl/PredictionApiIT.java b/translate/automl/src/test/java/com/google/cloud/translate/automl/PredictionApiIT.java
@@ -17,7 +17,6 @@
 package com.google.cloud.translate.automl;
 
 import static com.google.common.truth.Truth.assertThat;
-import static java.lang.Boolean.FALSE;
 
 import java.io.ByteArrayOutputStream;
 import java.io.PrintStream;
diff --git a/vision/automl/pom.xml b/vision/automl/pom.xml
@@ -15,7 +15,7 @@
 -->
 <project>
   <modelVersion>4.0.0</modelVersion>
-  <groupId>com.example.vision</groupId>
+  <groupId>com.example.vision.samples.automl</groupId>
   <artifactId>vision-automl</artifactId>
   <packaging>jar</packaging>
 

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@`
`45`	`45`	`*/`
`46`	`46`	`public class DatasetApi {`
`47`	`47`
`48`		`- // [START automl_translate_create_dataset]`
	`48`	`+ // [START automl_translation_create_dataset]`
`49`	`49`	`/**`
`50`	`50`	`* Demonstrates using the AutoML client to create a dataset`
`51`	`51`	`*`