Check on status 304 and add Content-Type header

mattpass · mattpass · commit 7c6b1d996815 · 2012-07-19T09:47:11.000+01:00
Looked into jQuery lib and found their XHR also checks on a 304 status
(Not Modified)
Added to success condition
Content-Type header added to also tie in with original jQuery version of
github.js
diff --git a/github.js b/github.js
@@ -19,14 +19,15 @@
       xhr.open(method, API_URL + path);
       xhr.onreadystatechange = function () {
         if (this.readyState == 4) {
-          if (this.status >= 200 && this.status < 300) {
+          if (this.status >= 200 && this.status < 300 || this.status === 304) {
             cb(null, raw ? this.responseText : JSON.parse(this.responseText));
           } else {
             cb(this.status);
           }
         }
       }
       xhr.setRequestHeader('Accept','application/vnd.github.raw');
+      xhr.setRequestHeader('Content-Type','application/x-www-form-urlencoded');
       if (
          (options.auth == 'oauth' && options.token) ||
          (options.auth == 'basic' && options.username && options.password)

Original file line number	Diff line number	Diff line change
`@@ -19,14 +19,15 @@`
`19`	`19`	`xhr.open(method, API_URL + path);`
`20`	`20`	`xhr.onreadystatechange = function () {`
`21`	`21`	`if (this.readyState == 4) {`
`22`		`- if (this.status >= 200 && this.status < 300) {`
	`22`	`+ if (this.status >= 200 && this.status < 300 \|\| this.status === 304) {`
`23`	`23`	`cb(null, raw ? this.responseText : JSON.parse(this.responseText));`
`24`	`24`	`} else {`
`25`	`25`	`cb(this.status);`
`26`	`26`	`}`
`27`	`27`	`}`
`28`	`28`	`}`
`29`	`29`	`xhr.setRequestHeader('Accept','application/vnd.github.raw');`
	`30`	`+ xhr.setRequestHeader('Content-Type','application/x-www-form-urlencoded');`
`30`	`31`	`if (`
`31`	`32`	`(options.auth == 'oauth' && options.token) \|\|`
`32`	`33`	`(options.auth == 'basic' && options.username && options.password)`