Skip to content

Commit d4af068

Browse files
authored
ci: Add example test for sql registry using in-memory sqlite (feast-dev#3012)
Signed-off-by: Achal Shah <achals@gmail.com>
1 parent 66c4338 commit d4af068

1 file changed

Lines changed: 36 additions & 5 deletions

File tree

sdk/python/tests/integration/registration/test_sql_registry.py

Lines changed: 36 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -108,13 +108,28 @@ def mysql_registry():
108108
container.stop()
109109

110110

111+
@pytest.fixture(scope="session")
112+
def sqlite_registry():
113+
114+
registry_config = RegistryConfig(
115+
registry_type="sql",
116+
path="sqlite://",
117+
)
118+
119+
yield SqlRegistry(registry_config, None)
120+
121+
111122
@pytest.mark.skipif(
112123
sys.platform == "darwin" and "GITHUB_REF" in os.environ,
113124
reason="does not run on mac github actions",
114125
)
115126
@pytest.mark.parametrize(
116127
"sql_registry",
117-
[lazy_fixture("mysql_registry"), lazy_fixture("pg_registry")],
128+
[
129+
lazy_fixture("mysql_registry"),
130+
lazy_fixture("pg_registry"),
131+
lazy_fixture("sqlite_registry"),
132+
],
118133
)
119134
def test_apply_entity_success(sql_registry):
120135
entity = Entity(
@@ -174,7 +189,11 @@ def assert_project_uuid(project, project_uuid, sql_registry):
174189
)
175190
@pytest.mark.parametrize(
176191
"sql_registry",
177-
[lazy_fixture("mysql_registry"), lazy_fixture("pg_registry")],
192+
[
193+
lazy_fixture("mysql_registry"),
194+
lazy_fixture("pg_registry"),
195+
lazy_fixture("sqlite_registry"),
196+
],
178197
)
179198
def test_apply_feature_view_success(sql_registry):
180199
# Create Feature Views
@@ -250,7 +269,11 @@ def test_apply_feature_view_success(sql_registry):
250269
)
251270
@pytest.mark.parametrize(
252271
"sql_registry",
253-
[lazy_fixture("mysql_registry"), lazy_fixture("pg_registry")],
272+
[
273+
lazy_fixture("mysql_registry"),
274+
lazy_fixture("pg_registry"),
275+
lazy_fixture("sqlite_registry"),
276+
],
254277
)
255278
def test_apply_on_demand_feature_view_success(sql_registry):
256279
# Create Feature Views
@@ -334,7 +357,11 @@ def location_features_from_push(inputs: pd.DataFrame) -> pd.DataFrame:
334357
)
335358
@pytest.mark.parametrize(
336359
"sql_registry",
337-
[lazy_fixture("mysql_registry"), lazy_fixture("pg_registry")],
360+
[
361+
lazy_fixture("mysql_registry"),
362+
lazy_fixture("pg_registry"),
363+
lazy_fixture("sqlite_registry"),
364+
],
338365
)
339366
@pytest.mark.parametrize(
340367
"request_source_schema",
@@ -462,7 +489,11 @@ def odfv1(feature_df: pd.DataFrame) -> pd.DataFrame:
462489
@pytest.mark.integration
463490
@pytest.mark.parametrize(
464491
"sql_registry",
465-
[lazy_fixture("mysql_registry"), lazy_fixture("pg_registry")],
492+
[
493+
lazy_fixture("mysql_registry"),
494+
lazy_fixture("pg_registry"),
495+
lazy_fixture("sqlite_registry"),
496+
],
466497
)
467498
def test_apply_data_source(sql_registry):
468499
# Create Feature Views

0 commit comments

Comments
 (0)