Skip to content

Commit 305842f

Browse files
authored
Move OfflineStore into Provider (feast-dev#1437)
Signed-off-by: Willem Pienaar <git@willem.co>
1 parent cd75008 commit 305842f

7 files changed

Lines changed: 605 additions & 654 deletions

File tree

sdk/python/feast/driver_test_data.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import numpy as np
33
import pandas as pd
44

5-
from feast.offline_store import ENTITY_DF_EVENT_TIMESTAMP_COL
5+
from feast.infra.provider import ENTITY_DF_EVENT_TIMESTAMP_COL
66

77

88
def create_orders_df(

sdk/python/feast/feature_store.py

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,7 @@
2121

2222
from feast.entity import Entity
2323
from feast.feature_view import FeatureView
24-
from feast.infra.provider import Provider, get_provider
25-
from feast.offline_store import (
26-
RetrievalJob,
27-
get_offline_store,
28-
get_offline_store_for_retrieval,
29-
)
24+
from feast.infra.provider import Provider, RetrievalJob, get_provider
3025
from feast.online_response import OnlineResponse, _infer_online_entity_rows
3126
from feast.protos.feast.serving.ServingService_pb2 import (
3227
GetOnlineFeaturesRequestV2,
@@ -255,8 +250,8 @@ def get_historical_features(
255250
project=self.config.project
256251
)
257252
feature_views = _get_requested_feature_views(feature_refs, all_feature_views)
258-
offline_store = get_offline_store_for_retrieval(feature_views)
259-
job = offline_store.get_historical_features(
253+
provider = self._get_provider()
254+
job = provider.get_historical_features(
260255
self.config, feature_views, feature_refs, entity_df
261256
)
262257
return job
@@ -367,9 +362,8 @@ def _materialize_single_feature_view(
367362
event_timestamp_column,
368363
created_timestamp_column,
369364
) = _run_reverse_field_mapping(feature_view)
370-
371-
offline_store = get_offline_store(self.config)
372-
table = offline_store.pull_latest_from_table_or_query(
365+
provider = self._get_provider()
366+
table = provider.pull_latest_from_table_or_query(
373367
feature_view.input,
374368
entity_names,
375369
feature_names,

0 commit comments

Comments
 (0)