try to encode an object with custom encoder to override built-in's

gfx · gfx · commit a5a5d1bc7f19 · 2019-06-11T23:11:29.000+09:00
diff --git a/package.json b/package.json
@@ -24,7 +24,7 @@
     "test:cover:wasm": "npx nyc --no-clean npm run test:wasm",
     "test:cover:td": "npx nyc --no-clean npm run test:td",
     "cover:clean": "rimraf .nyc_output coverage/",
-    "cover:report": "nyc report --reporter=text-summary --reporter=html --reporter=json",
+    "cover:report": "npx nyc report --reporter=text-summary --reporter=html --reporter=json",
     "test:browser": "karma start --single-run",
     "test:browser:firefox": "karma start --single-run --browsers FirefoxHeadless",
     "test:browser:chrome": "karma start --single-run --browsers ChromeHeadless",
diff --git a/src/ExtensionCodec.ts b/src/ExtensionCodec.ts
@@ -50,25 +50,25 @@ export class ExtensionCodec implements ExtensionCodecType {
   }
 
   public tryToEncode(object: unknown): ExtData | null {
-    // built-in extensions
-    for (let i = 0; i < this.builtInEncoders.length; i++) {
-      const encoder = this.builtInEncoders[i];
+    // custom extensions
+    for (let i = 0; i < this.encoders.length; i++) {
+      const encoder = this.encoders[i];
       if (encoder != null) {
         const data = encoder(object);
         if (data != null) {
-          const type = -1 - i;
+          const type = i;
           return new ExtData(type, data);
         }
       }
     }
 
-    // custom extensions
-    for (let i = 0; i < this.encoders.length; i++) {
-      const encoder = this.encoders[i];
+    // built-in extensions
+    for (let i = 0; i < this.builtInEncoders.length; i++) {
+      const encoder = this.builtInEncoders[i];
       if (encoder != null) {
         const data = encoder(object);
         if (data != null) {
-          const type = i;
+          const type = -1 - i;
           return new ExtData(type, data);
         }
       }

Original file line number	Diff line number	Diff line change
`@@ -50,25 +50,25 @@ export class ExtensionCodec implements ExtensionCodecType {`
`50`	`50`	`}`
`51`	`51`
`52`	`52`	`public tryToEncode(object: unknown): ExtData \| null {`
`53`		`- // built-in extensions`
`54`		`- for (let i = 0; i < this.builtInEncoders.length; i++) {`
`55`		`- const encoder = this.builtInEncoders[i];`
	`53`	`+ // custom extensions`
	`54`	`+ for (let i = 0; i < this.encoders.length; i++) {`
	`55`	`+ const encoder = this.encoders[i];`
`56`	`56`	`if (encoder != null) {`
`57`	`57`	`const data = encoder(object);`
`58`	`58`	`if (data != null) {`
`59`		`- const type = -1 - i;`
	`59`	`+ const type = i;`
`60`	`60`	`return new ExtData(type, data);`
`61`	`61`	`}`
`62`	`62`	`}`
`63`	`63`	`}`
`64`	`64`
`65`		`- // custom extensions`
`66`		`- for (let i = 0; i < this.encoders.length; i++) {`
`67`		`- const encoder = this.encoders[i];`
	`65`	`+ // built-in extensions`
	`66`	`+ for (let i = 0; i < this.builtInEncoders.length; i++) {`
	`67`	`+ const encoder = this.builtInEncoders[i];`
`68`	`68`	`if (encoder != null) {`
`69`	`69`	`const data = encoder(object);`
`70`	`70`	`if (data != null) {`
`71`		`- const type = i;`
	`71`	`+ const type = -1 - i;`
`72`	`72`	`return new ExtData(type, data);`
`73`	`73`	`}`
`74`	`74`	`}`