ValueFactory: updated argument name from ref to omitCopy

frsyuki · frsyuki · commit fbc19770d38b · 2016-01-06T11:26:25.000-08:00
diff --git a/msgpack-core/src/main/java/org/msgpack/value/ValueFactory.java b/msgpack-core/src/main/java/org/msgpack/value/ValueFactory.java
@@ -90,9 +90,9 @@ public static ImmutableBinaryValue newBinary(byte[] b)
         return newBinary(b, false);
     }
 
-    public static ImmutableBinaryValue newBinary(byte[] b, boolean ref)
+    public static ImmutableBinaryValue newBinary(byte[] b, boolean omitCopy)
     {
-        if (ref) {
+        if (omitCopy) {
             return new ImmutableBinaryValueImpl(b);
         }
         else {
@@ -105,9 +105,9 @@ public static ImmutableBinaryValue newBinary(byte[] b, int off, int len)
         return newBinary(b, off, len, false);
     }
 
-    public static ImmutableBinaryValue newBinary(byte[] b, int off, int len, boolean ref)
+    public static ImmutableBinaryValue newBinary(byte[] b, int off, int len, boolean omitCopy)
     {
-        if (ref && off == 0 && len == b.length) {
+        if (omitCopy && off == 0 && len == b.length) {
             return new ImmutableBinaryValueImpl(b);
         }
         else {
@@ -125,9 +125,9 @@ public static ImmutableStringValue newString(byte[] b)
         return new ImmutableStringValueImpl(b);
     }
 
-    public static ImmutableStringValue newString(byte[] b, boolean ref)
+    public static ImmutableStringValue newString(byte[] b, boolean omitCopy)
     {
-        if (ref) {
+        if (omitCopy) {
             return new ImmutableStringValueImpl(b);
         }
         else {
@@ -140,9 +140,9 @@ public static ImmutableStringValue newString(byte[] b, int off, int len)
         return newString(b, off, len, false);
     }
 
-    public static ImmutableStringValue newString(byte[] b, int off, int len, boolean ref)
+    public static ImmutableStringValue newString(byte[] b, int off, int len, boolean omitCopy)
     {
-        if (ref && off == 0 && len == b.length) {
+        if (omitCopy && off == 0 && len == b.length) {
             return new ImmutableStringValueImpl(b);
         }
         else {
@@ -169,12 +169,12 @@ public static ImmutableArrayValue newArray(Value... array)
         }
     }
 
-    public static ImmutableArrayValue newArray(Value[] array, boolean ref)
+    public static ImmutableArrayValue newArray(Value[] array, boolean omitCopy)
     {
         if (array.length == 0) {
             return ImmutableArrayValueImpl.empty();
         }
-        else if (ref) {
+        else if (omitCopy) {
             return new ImmutableArrayValueImpl(array);
         }
         else {
@@ -213,12 +213,12 @@ public static ImmutableMapValue newMap(Value... kvs)
         }
     }
 
-    public static ImmutableMapValue newMap(Value[] kvs, boolean ref)
+    public static ImmutableMapValue newMap(Value[] kvs, boolean omitCopy)
     {
         if (kvs.length == 0) {
             return ImmutableMapValueImpl.empty();
         }
-        else if (ref) {
+        else if (omitCopy) {
             return new ImmutableMapValueImpl(kvs);
         }
         else {

Original file line number	Diff line number	Diff line change
`@@ -90,9 +90,9 @@ public static ImmutableBinaryValue newBinary(byte[] b)`
`90`	`90`	`return newBinary(b, false);`
`91`	`91`	`}`
`92`	`92`
`93`		`- public static ImmutableBinaryValue newBinary(byte[] b, boolean ref)`
	`93`	`+ public static ImmutableBinaryValue newBinary(byte[] b, boolean omitCopy)`
`94`	`94`	`{`
`95`		`- if (ref) {`
	`95`	`+ if (omitCopy) {`
`96`	`96`	`return new ImmutableBinaryValueImpl(b);`
`97`	`97`	`}`
`98`	`98`	`else {`
`@@ -105,9 +105,9 @@ public static ImmutableBinaryValue newBinary(byte[] b, int off, int len)`
`105`	`105`	`return newBinary(b, off, len, false);`
`106`	`106`	`}`
`107`	`107`
`108`		`- public static ImmutableBinaryValue newBinary(byte[] b, int off, int len, boolean ref)`
	`108`	`+ public static ImmutableBinaryValue newBinary(byte[] b, int off, int len, boolean omitCopy)`
`109`	`109`	`{`
`110`		`- if (ref && off == 0 && len == b.length) {`
	`110`	`+ if (omitCopy && off == 0 && len == b.length) {`
`111`	`111`	`return new ImmutableBinaryValueImpl(b);`
`112`	`112`	`}`
`113`	`113`	`else {`
`@@ -125,9 +125,9 @@ public static ImmutableStringValue newString(byte[] b)`
`125`	`125`	`return new ImmutableStringValueImpl(b);`
`126`	`126`	`}`
`127`	`127`
`128`		`- public static ImmutableStringValue newString(byte[] b, boolean ref)`
	`128`	`+ public static ImmutableStringValue newString(byte[] b, boolean omitCopy)`
`129`	`129`	`{`
`130`		`- if (ref) {`
	`130`	`+ if (omitCopy) {`
`131`	`131`	`return new ImmutableStringValueImpl(b);`
`132`	`132`	`}`
`133`	`133`	`else {`
`@@ -140,9 +140,9 @@ public static ImmutableStringValue newString(byte[] b, int off, int len)`
`140`	`140`	`return newString(b, off, len, false);`
`141`	`141`	`}`
`142`	`142`
`143`		`- public static ImmutableStringValue newString(byte[] b, int off, int len, boolean ref)`
	`143`	`+ public static ImmutableStringValue newString(byte[] b, int off, int len, boolean omitCopy)`
`144`	`144`	`{`
`145`		`- if (ref && off == 0 && len == b.length) {`
	`145`	`+ if (omitCopy && off == 0 && len == b.length) {`
`146`	`146`	`return new ImmutableStringValueImpl(b);`
`147`	`147`	`}`
`148`	`148`	`else {`
`@@ -169,12 +169,12 @@ public static ImmutableArrayValue newArray(Value... array)`
`169`	`169`	`}`
`170`	`170`	`}`
`171`	`171`
`172`		`- public static ImmutableArrayValue newArray(Value[] array, boolean ref)`
	`172`	`+ public static ImmutableArrayValue newArray(Value[] array, boolean omitCopy)`
`173`	`173`	`{`
`174`	`174`	`if (array.length == 0) {`
`175`	`175`	`return ImmutableArrayValueImpl.empty();`
`176`	`176`	`}`
`177`		`- else if (ref) {`
	`177`	`+ else if (omitCopy) {`
`178`	`178`	`return new ImmutableArrayValueImpl(array);`
`179`	`179`	`}`
`180`	`180`	`else {`
`@@ -213,12 +213,12 @@ public static ImmutableMapValue newMap(Value... kvs)`
`213`	`213`	`}`
`214`	`214`	`}`
`215`	`215`
`216`		`- public static ImmutableMapValue newMap(Value[] kvs, boolean ref)`
	`216`	`+ public static ImmutableMapValue newMap(Value[] kvs, boolean omitCopy)`
`217`	`217`	`{`
`218`	`218`	`if (kvs.length == 0) {`
`219`	`219`	`return ImmutableMapValueImpl.empty();`
`220`	`220`	`}`
`221`		`- else if (ref) {`
	`221`	`+ else if (omitCopy) {`
`222`	`222`	`return new ImmutableMapValueImpl(kvs);`
`223`	`223`	`}`
`224`	`224`	`else {`