Fix BigIntegerAccept to read byte/short values correctly

oza · oza · commit e37e03af7c1b · 2014-02-20T10:36:53.000-08:00
Signed-off-by: Tsuyoshi Ozawa &lt;ozawa.tsuyoshi@gmail.com&gt;
diff --git a/src/main/java/org/msgpack/unpacker/BigIntegerAccept.java b/src/main/java/org/msgpack/unpacker/BigIntegerAccept.java
@@ -48,12 +48,12 @@ void acceptInteger(long v) {
 
     @Override
     void acceptUnsignedInteger(byte v) {
-        BigInteger.valueOf((long) (v & 0xff));
+        this.value = BigInteger.valueOf((long) (v & 0xff));
     }
 
     @Override
     void acceptUnsignedInteger(short v) {
-        BigInteger.valueOf((long) (v & 0xffff));
+        this.value = BigInteger.valueOf((long) (v & 0xffff));
     }
 
     @Override
diff --git a/src/test/java/org/msgpack/TestSet.java b/src/test/java/org/msgpack/TestSet.java
@@ -398,6 +398,8 @@ public void testBigInteger() throws Exception {
         testBigInteger(BigInteger.valueOf(0));
         testBigInteger(BigInteger.valueOf(-1));
         testBigInteger(BigInteger.valueOf(1));
+        testBigInteger(BigInteger.valueOf(128l));
+        testBigInteger(BigInteger.valueOf(512l));
         testBigInteger(BigInteger.valueOf(Integer.MIN_VALUE));
         testBigInteger(BigInteger.valueOf(Integer.MAX_VALUE));
         testBigInteger(BigInteger.valueOf(Long.MIN_VALUE));

Original file line number	Diff line number	Diff line change
`@@ -48,12 +48,12 @@ void acceptInteger(long v) {`
`48`	`48`
`49`	`49`	`@Override`
`50`	`50`	`void acceptUnsignedInteger(byte v) {`
`51`		`- BigInteger.valueOf((long) (v & 0xff));`
	`51`	`+ this.value = BigInteger.valueOf((long) (v & 0xff));`
`52`	`52`	`}`
`53`	`53`
`54`	`54`	`@Override`
`55`	`55`	`void acceptUnsignedInteger(short v) {`
`56`		`- BigInteger.valueOf((long) (v & 0xffff));`
	`56`	`+ this.value = BigInteger.valueOf((long) (v & 0xffff));`
`57`	`57`	`}`
`58`	`58`
`59`	`59`	`@Override`