Merge pull request #139 from benjamin-bader/no-exception-printing

komamitsu · komamitsu · commit 8461d9d5bc71 · 2014-12-07T22:34:20.000+09:00
Replacing calls to `Exception#printStackTrace()` with Java logging.
diff --git a/src/main/java/org/msgpack/template/builder/JavassistTemplateBuilder.java b/src/main/java/org/msgpack/template/builder/JavassistTemplateBuilder.java
@@ -73,8 +73,9 @@ public JavassistTemplateBuilder(TemplateRegistry registry, ClassLoader cl) {
                 appended = true;
             }
         } catch (SecurityException e) {
-            LOG.fine("Cannot append a search path of classloader");
-            e.printStackTrace();
+            if (LOG.isLoggable(Level.WARNING)) {
+                LOG.log(Level.WARNING, "Cannot append a search path of classloader", e);
+            }
         }
         if (!appended) {
             pool.appendSystemPath();
diff --git a/src/main/java/org/msgpack/template/builder/TemplateBuilderChain.java b/src/main/java/org/msgpack/template/builder/TemplateBuilderChain.java
@@ -22,15 +22,19 @@
 import java.lang.reflect.Type;
 import java.util.ArrayList;
 import java.util.List;
+import java.util.logging.Level;
+import java.util.logging.Logger;
 
 import org.msgpack.template.TemplateRegistry;
 import org.msgpack.util.android.DalvikVmChecker;
 
 public class TemplateBuilderChain {
-	private static final String JAVASSIST_TEMPLATE_BUILDER_CLASS_NAME =
-			"org.msgpack.template.builder.JavassistTemplateBuilder";
-	private static final String REFLECTION_TEMPLATE_BUILDER_CLASS_NAME =
-			"org.msgpack.template.builder.ReflectionTemplateBuilder";
+    private static final Logger LOG = Logger.getLogger(TemplateBuilderChain.class.getName());
+
+    private static final String JAVASSIST_TEMPLATE_BUILDER_CLASS_NAME =
+            "org.msgpack.template.builder.JavassistTemplateBuilder";
+    private static final String REFLECTION_TEMPLATE_BUILDER_CLASS_NAME =
+            "org.msgpack.template.builder.ReflectionTemplateBuilder";
 
     private static boolean enableDynamicCodeGeneration() {
         return !DalvikVmChecker.isDalvikVm() &&
@@ -74,16 +78,18 @@ protected void reset(final TemplateRegistry registry, final ClassLoader cl) {
         templateBuilders.add(new ReflectionBeansTemplateBuilder(registry));
     }
 
-	private static TemplateBuilder createForceTemplateBuilder(String className,
-			TemplateRegistry registry, ClassLoader cl) {
-		try {
-			Class<?> c = (Class<?>) Class.forName(className);
-			Constructor<?> cons = c.getConstructor(TemplateRegistry.class,
-					ClassLoader.class);
-			return (TemplateBuilder) cons.newInstance(registry, cl);
-		} catch (Exception e) {
-		    e.printStackTrace();
-		}
+    private static TemplateBuilder createForceTemplateBuilder(String className,
+            TemplateRegistry registry, ClassLoader cl) {
+        try {
+            Class<?> c = (Class<?>) Class.forName(className);
+            Constructor<?> cons = c.getConstructor(TemplateRegistry.class,
+                    ClassLoader.class);
+            return (TemplateBuilder) cons.newInstance(registry, cl);
+        } catch (Exception e) {
+            if (LOG.isLoggable(Level.WARNING)) {
+                LOG.log(Level.WARNING, "Failed to create a TemplateBuilder reflectively", e);
+            }
+        }
         return new ReflectionTemplateBuilder(registry, cl);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -73,8 +73,9 @@ public JavassistTemplateBuilder(TemplateRegistry registry, ClassLoader cl) {`
`73`	`73`	`appended = true;`
`74`	`74`	`}`
`75`	`75`	`} catch (SecurityException e) {`
`76`		`- LOG.fine("Cannot append a search path of classloader");`
`77`		`- e.printStackTrace();`
	`76`	`+ if (LOG.isLoggable(Level.WARNING)) {`
	`77`	`+ LOG.log(Level.WARNING, "Cannot append a search path of classloader", e);`
	`78`	`+ }`
`78`	`79`	`}`
`79`	`80`	`if (!appended) {`
`80`	`81`	`pool.appendSystemPath();`