Merge pull request #287 from mecp/v07-develop

komamitsu · komamitsu · commit 610553e2041b · 2015-11-11T23:28:14.000+09:00
asShort in ImmutableLongValueImpl should check isInShortRange
diff --git a/msgpack-core/src/main/java/org/msgpack/value/impl/ImmutableLongValueImpl.java b/msgpack-core/src/main/java/org/msgpack/value/impl/ImmutableLongValueImpl.java
@@ -158,7 +158,7 @@ public byte asByte()
     @Override
     public short asShort()
     {
-        if (!isInByteRange()) {
+        if (!isInShortRange()) {
             throw new MessageIntegerOverflowException(value);
         }
         return (short) value;
diff --git a/msgpack-core/src/test/scala/org/msgpack/value/ValueTest.scala b/msgpack-core/src/test/scala/org/msgpack/value/ValueTest.scala
@@ -16,7 +16,6 @@
 package org.msgpack.value
 
 import java.math.BigInteger
-
 import org.msgpack.core._
 
 import scala.util.parsing.json.JSON
@@ -97,5 +96,35 @@ class ValueTest extends MessagePackSpec
 
     }
 
+    "check appropriate range for integers" in {
+      import ValueFactory._
+      import java.lang.Byte
+      import java.lang.Short
+
+      newInteger(Byte.MAX_VALUE).asByte() shouldBe Byte.MAX_VALUE
+      newInteger(Byte.MIN_VALUE).asByte() shouldBe Byte.MIN_VALUE
+      newInteger(Short.MAX_VALUE).asShort() shouldBe Short.MAX_VALUE
+      newInteger(Short.MIN_VALUE).asShort() shouldBe Short.MIN_VALUE
+      newInteger(Integer.MAX_VALUE).asInt() shouldBe Integer.MAX_VALUE
+      newInteger(Integer.MIN_VALUE).asInt() shouldBe Integer.MIN_VALUE
+      intercept[MessageIntegerOverflowException] {
+        newInteger(Byte.MAX_VALUE+1).asByte()
+      }
+      intercept[MessageIntegerOverflowException] {
+        newInteger(Byte.MIN_VALUE-1).asByte()
+      }
+      intercept[MessageIntegerOverflowException] {
+        newInteger(Short.MAX_VALUE+1).asShort()
+      }
+      intercept[MessageIntegerOverflowException] {
+        newInteger(Short.MIN_VALUE-1).asShort()
+      }
+      intercept[MessageIntegerOverflowException] {
+        newInteger(Integer.MAX_VALUE+1.toLong).asInt()
+      }
+      intercept[MessageIntegerOverflowException] {
+        newInteger(Integer.MIN_VALUE-1.toLong).asInt()
+      }
+    }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -158,7 +158,7 @@ public byte asByte()`
`158`	`158`	`@Override`
`159`	`159`	`public short asShort()`
`160`	`160`	`{`
`161`		`- if (!isInByteRange()) {`
	`161`	`+ if (!isInShortRange()) {`
`162`	`162`	`throw new MessageIntegerOverflowException(value);`
`163`	`163`	`}`
`164`	`164`	`return (short) value;`