Fixes based on Review Comments

ShrenikOne · ShrenikOne · commit ec787d73b18f · 2018-02-14T10:21:04.000+05:30
diff --git a/src/MsgPack/Serialization/BindingOptions.cs b/src/MsgPack/Serialization/BindingOptions.cs
@@ -77,5 +77,24 @@ public IEnumerable<string> GetIgnoringMembers( Type targetType )
 				}
 			}
 		}
+
+		/// <summary>
+		/// Gets all registered types specific ignoring members.
+		/// </summary>
+		/// <returns>Returns all registered types specific ignoring members.</returns>
+		public IReadOnlyDictionary<Type, IEnumerable<string>> GetAllIgnoringMembers()
+		{
+			Dictionary<Type, IEnumerable<string>> map = new Dictionary<Type, IEnumerable<string>>();
+			lock ( this.typeIgnoringMembersMap )
+			{
+				foreach ( var item in this.typeIgnoringMembersMap )
+				{
+					//// These to make sure that Property list doesn't used as reference type.
+					map.Add( item.Key, item.Value.ToArray() );
+				}
+			}
+
+			return map;
+		}
 	}
 }
diff --git a/src/MsgPack/Serialization/SerializationTarget.cs b/src/MsgPack/Serialization/SerializationTarget.cs
@@ -639,13 +639,14 @@ private static bool CheckTargetEligibility( SerializationContext context, Member
 			{
 				case CollectionKind.Array:
 				case CollectionKind.Map:
-					{
-						return traits.AddMethod != null;
-					}
+				{
+					return traits.AddMethod != null;
+				}
+
 				default:
-					{
-						return false;
-					}
+				{
+					return false;
+				}
 			}
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -77,5 +77,24 @@ public IEnumerable<string> GetIgnoringMembers( Type targetType )`
`77`	`77`	`}`
`78`	`78`	`}`
`79`	`79`	`}`
	`80`	`+`
	`81`	`+ /// <summary>`
	`82`	`+ /// Gets all registered types specific ignoring members.`
	`83`	`+ /// </summary>`
	`84`	`+ /// <returns>Returns all registered types specific ignoring members.</returns>`
	`85`	`+ public IReadOnlyDictionary<Type, IEnumerable<string>> GetAllIgnoringMembers()`
	`86`	`+ {`
	`87`	`+ Dictionary<Type, IEnumerable<string>> map = new Dictionary<Type, IEnumerable<string>>();`
	`88`	`+ lock ( this.typeIgnoringMembersMap )`
	`89`	`+ {`
	`90`	`+ foreach ( var item in this.typeIgnoringMembersMap )`
	`91`	`+ {`
	`92`	`+ //// These to make sure that Property list doesn't used as reference type.`
	`93`	`+ map.Add( item.Key, item.Value.ToArray() );`
	`94`	`+ }`
	`95`	`+ }`
	`96`	`+`
	`97`	`+ return map;`
	`98`	`+ }`
`80`	`99`	`}`
`81`	`100`	`}`