Fix map keys order inconsistency.

yfakariya · yfakariya · commit e389fe8bfb8a · 2018-04-30T23:21:14.000+09:00
This commit fixes the issue that map keys order emitted by asymmetric
(serialization only) serializer are inconsistent across platform because they
are not sorted due to incorrect flow.
diff --git a/CHANGES.txt b/CHANGES.txt
@@ -750,4 +750,4 @@ Release 1.0.0
 
   BUG FIXES
   * [NonSerialized] attribute does not effect in Mono based platform including Unity.
-
+  * Fix map keys order emitted by asymmetric (serialization only) serializer are inconsistent across platform.
diff --git a/src/MsgPack/Serialization/SerializationTarget.cs b/src/MsgPack/Serialization/SerializationTarget.cs
@@ -193,7 +193,7 @@ public static SerializationTarget Prepare( SerializationContext context, Type ta
 
 			var memberCandidates = getters.Where( entry => CheckTargetEligibility( context, entry.Member ) ).ToArray();
 
-			if ( memberCandidates.Length == 0 )
+			if ( memberCandidates.Length == 0 && !context.CompatibilityOptions.AllowAsymmetricSerializer )
 			{
 				ConstructorKind constructorKind;
 				var deserializationConstructor = FindDeserializationConstructor( context, targetType, out constructorKind );
@@ -226,6 +226,15 @@ public static SerializationTarget Prepare( SerializationContext context, Type ta
 					constructor = deserializationConstructor;
 					canDeserialize = null;
 				}
+				else if ( memberCandidates.Length == 0 )
+				{
+#if DEBUG
+					Contract.Assert( context.CompatibilityOptions.AllowAsymmetricSerializer );
+#endif // DEBUG
+					// Absolutely cannot deserialize in this case.
+					canDeserialize = false;
+					constructorKind = ConstructorKind.Ambiguous;
+				}
 				else
 				{
 					constructorKind = ConstructorKind.Default;
@@ -243,7 +252,7 @@ public static SerializationTarget Prepare( SerializationContext context, Type ta
 					canDeserialize = true;
 				}
 
-				if ( constructor != null && constructor.GetParameters().Any() )
+				if ( constructor != null && constructor.GetParameters().Any() || context.CompatibilityOptions.AllowAsymmetricSerializer )
 				{
 					// Recalculate members because getter-only/readonly members should be included for constructor deserialization.
 					memberCandidates = getters;

Original file line number	Diff line number	Diff line change
`@@ -193,7 +193,7 @@ public static SerializationTarget Prepare( SerializationContext context, Type ta`
`193`	`193`
`194`	`194`	`var memberCandidates = getters.Where( entry => CheckTargetEligibility( context, entry.Member ) ).ToArray();`
`195`	`195`
`196`		`- if ( memberCandidates.Length == 0 )`
	`196`	`+ if ( memberCandidates.Length == 0 && !context.CompatibilityOptions.AllowAsymmetricSerializer )`
`197`	`197`	`{`
`198`	`198`	`ConstructorKind constructorKind;`
`199`	`199`	`var deserializationConstructor = FindDeserializationConstructor( context, targetType, out constructorKind );`
`@@ -226,6 +226,15 @@ public static SerializationTarget Prepare( SerializationContext context, Type ta`
`226`	`226`	`constructor = deserializationConstructor;`
`227`	`227`	`canDeserialize = null;`
`228`	`228`	`}`
	`229`	`+ else if ( memberCandidates.Length == 0 )`
	`230`	`+ {`
	`231`	`+#if DEBUG`
	`232`	`+ Contract.Assert( context.CompatibilityOptions.AllowAsymmetricSerializer );`
	`233`	`+#endif // DEBUG`
	`234`	`+ // Absolutely cannot deserialize in this case.`
	`235`	`+ canDeserialize = false;`
	`236`	`+ constructorKind = ConstructorKind.Ambiguous;`
	`237`	`+ }`
`229`	`238`	`else`
`230`	`239`	`{`
`231`	`240`	`constructorKind = ConstructorKind.Default;`
`@@ -243,7 +252,7 @@ public static SerializationTarget Prepare( SerializationContext context, Type ta`
`243`	`252`	`canDeserialize = true;`
`244`	`253`	`}`
`245`	`254`
`246`		`- if ( constructor != null && constructor.GetParameters().Any() )`
	`255`	`+ if ( constructor != null && constructor.GetParameters().Any() \|\| context.CompatibilityOptions.AllowAsymmetricSerializer )`
`247`	`256`	`{`
`248`	`257`	`// Recalculate members because getter-only/readonly members should be included for constructor deserialization.`
`249`	`258`	`memberCandidates = getters;`