reduce js loaded on wiki documents (#4980)

LeoMcA · web-flow · commit 59ddb253fec9 · 2022-01-05T17:53:42.000Z
reduce from 705KB to 302KB minified but uncompressed
diff --git a/kitsune/sumo/static/sumo/js/document.js b/kitsune/sumo/static/sumo/js/document.js
@@ -0,0 +1,29 @@
+import "sumo/js/libs/jquery.lazyload";
+import AjaxVote from "sumo/js/ajaxvote";
+import {
+  getQueryParamsAsDict,
+  getReferrer,
+  getSearchQuery,
+} from "sumo/js/main";
+import ShowFor from "sumo/js/showfor";
+
+new ShowFor();
+
+addReferrerAndQueryToVoteForm();
+new AjaxVote(".document-vote form", {
+  positionMessage: false,
+  replaceFormWithMessage: true,
+  removeForm: true,
+});
+
+$("img.lazy").lazyload();
+
+function addReferrerAndQueryToVoteForm() {
+  // Add the source/referrer and query terms to the helpful vote form
+  var urlParams = getQueryParamsAsDict(),
+    referrer = getReferrer(urlParams),
+    query = getSearchQuery(urlParams, referrer);
+  $(".document-vote form")
+    .append($('<input type="hidden" name="referrer"/>').attr("value", referrer))
+    .append($('<input type="hidden" name="query"/>').attr("value", query));
+}
diff --git a/kitsune/sumo/static/sumo/js/wiki.js b/kitsune/sumo/static/sumo/js/wiki.js
@@ -11,9 +11,7 @@ import "sumo/js/codemirror.sumo-hint";
 import "sumo/js/codemirror.sumo-mode";
 import "sumo/js/protocol";
 import AjaxPreview from "sumo/js/ajaxpreview";
-import AjaxVote from "sumo/js/ajaxvote";
 import { initDiff } from "sumo/js/diff";
-import { getQueryParamsAsDict, getReferrer, getSearchQuery, unquote } from "sumo/js/main";
 import Marky from "sumo/js/markup";
 import ShowFor from "sumo/js/showfor";
 
@@ -31,18 +29,7 @@ import ShowFor from "sumo/js/showfor";
     initPrepopulatedSlugs();
     initDetailsTags();
 
-    if ($body.is('.document')) {  // Document page
-      // Put last search query into search box
-      $('#support-search input[name=q]')
-        .val(unquote($.cookie('last_search')));
-      new ShowFor();
-      addReferrerAndQueryToVoteForm();
-      new AjaxVote('.document-vote form', {
-        positionMessage: false,
-        replaceFormWithMessage: true,
-        removeForm: true
-      });
-    } else if ($body.is('.review')) { // Review pages
+    if ($body.is('.review')) { // Review pages
       new ShowFor();
       initNeedsChange();
 
@@ -438,18 +425,6 @@ import ShowFor from "sumo/js/showfor";
     });
   }
 
-  function addReferrerAndQueryToVoteForm() {
-    // Add the source/referrer and query terms to the helpful vote form
-    var urlParams = getQueryParamsAsDict(),
-      referrer = getReferrer(urlParams),
-      query = getSearchQuery(urlParams, referrer);
-    $('.document-vote form')
-      .append($('<input type="hidden" name="referrer"/>')
-        .attr('value', referrer))
-      .append($('<input type="hidden" name="query"/>')
-        .attr('value', query));
-  }
-
   function initNeedsChange() {
     // Hide and show the comment box based on the status of the
     // "Needs change" checkbox. Also, make the textarea required
diff --git a/kitsune/wiki/jinja2/wiki/document.html b/kitsune/wiki/jinja2/wiki/document.html
@@ -7,7 +7,7 @@
 {% from "questions/includes/aaq_macros.html" import aaq_widget %}
 {% set classes = 'document' %}
 {% set canonical_url = canonicalize(model_url=document.get_absolute_url()) %}
-{% set scripts = ('wiki', 'questions') %}
+{% set scripts = ('document',) %}
 {% set extra_body_attrs = {'data-document-id': document.id, 'data-default-slug': document.parent.slug if document.parent else document.slug} %}
 
 {% block title %}
diff --git a/webpack/entrypoints.js b/webpack/entrypoints.js
@@ -32,6 +32,10 @@ const entrypoints = {
   "community.metrics": [
     "kpi/js/kpi.browserify.js",
   ],
+  document: [
+    "sumo/js/document.js",
+    "sumo/js/wiki.metrics.js",
+  ],
   questions: [
     "sumo/js/questions.js",
     "sumo/js/tags.filter.js",
@@ -62,10 +66,8 @@ const entrypoints = {
   wiki: [
     "sumo/js/users.autocomplete.js",
     "sumo/js/wiki.js",
-    "sumo/js/tags.js",
     "sumo/js/dashboards.js",
     "sumo/js/editable.js",
-    "sumo/js/wiki.metrics.js",
     "sumo/js/templates/wiki-related-doc.js",
     "sumo/js/templates/wiki-search-results.js",
     "sumo/js/wiki_search.js",
