Skip to content

Commit f758090

Browse files
injustJ0WI
authored andcommitted
Update ruleset: Consumer Reports (EFForg#17121)
* Remove non-capturing groups * Handle custhelp.consumerreports.org here * Delete RightNow-clients.xml * Remove non-capturing groups * Delete Consumer_Reports.com-falsemixed.xml * Migrate rules from Consumer_Reports.com-falsemixed.xml - HSTS is set on web.consumerreports.org - Certificate is valid for consumerreports.org - No MCB on excluded URLs * Clean up ruleset * Oops
1 parent 4698d60 commit f758090

File tree

3 files changed

+12
-110
lines changed

3 files changed

+12
-110
lines changed
Lines changed: 12 additions & 72 deletions
Original file line numberDiff line numberDiff line change
@@ -1,80 +1,20 @@
1-
<!--
2-
For rules causing false/broken MCB, see Consumer_Reports.com-falsemixed.xml.
3-
4-
consumerreports.custhelp.com is handled in RightNow-clients.xml.
5-
6-
7-
CDN buckets:
8-
9-
- dffe75s34hxl9.cloudfront.net
10-
- static[1-4].consumerreportscdn.org
11-
12-
- news-consumerreports-org-1342602336.us-east-1.elb.amazonaws.com
13-
- news.consumerreports.org
14-
15-
16-
Nonfunctional domains:
17-
18-
- news.consumerreports.org
19-
20-
21-
Problematic domains:
22-
23-
- (www.)consumerreports.org *
24-
- web.consumerreports.org *
25-
26-
* Mixed css
27-
28-
29-
Insecure cookies are set for these domains:
30-
31-
- .
32-
- ec
33-
34-
35-
Mixed content:
36-
37-
- css on web and www from static[1-4].consumerreportscdn.org *
38-
39-
* Secured by us
40-
41-
-->
42-
<ruleset name="Consumer Reports (partial)">
43-
1+
<ruleset name="Consumer Reports">
2+
<!-- consumerreports.org -->
443
<target host="consumerreports.org" />
4+
<target host="www.consumerreports.org" />
5+
<target host="custhelp.consumerreports.org" />
456
<target host="ec.consumerreports.org" />
7+
<target host="news.consumerreports.org" />
468
<target host="web.consumerreports.org" />
47-
<target host="www.consumerreports.org" />
48-
<!--
49-
Avoid broken MCB:
50-
-->
51-
<exclusion pattern="^http://(?:web\.|www\.)?consumerreports\.org/+(?!etc/|favicon\.ico)" />
52-
<target host="*.consumerreportscdn.org" />
539

54-
55-
<!-- Not secured by server:
56-
-->
57-
<!--securecookie host="^\.consumerreports\.org$" name="^(userKeycodes|userReferrer)$" /-->
58-
<!--securecookie host="^ec\.consumerreports\.org$" name="^(JSESSIONID|pwipersist)$" /-->
10+
<!-- consumerreportscdn.org -->
11+
<target host="static1.consumerreportscdn.org" />
12+
<target host="static2.consumerreportscdn.org" />
13+
<target host="static3.consumerreportscdn.org" />
14+
<target host="static4.consumerreportscdn.org" />
15+
<target host="static5.consumerreportscdn.org" />
5916

6017
<securecookie host="^ec\.consumerreports\.org$" name=".+" />
6118

62-
63-
<!-- Cert only matches www.
64-
-->
65-
<rule from="^http://(?:www\.)?consumerreports\.org/"
66-
to="https://www.consumerreports.org/" />
67-
68-
<!-- Many (all?) paths 301 back.
69-
70-
<rule from="^http://custhelp\.consumerreports\.org/"
71-
to="https://consumerreports.custhelp.com/" /-->
72-
73-
<rule from="^http://(ec|web)\.consumerreports\.org/"
74-
to="https://$1.consumerreports.org/" />
75-
76-
<rule from="^http://static[1-4]\.consumerreportscdn\.org/"
77-
to="https://dffe75s34hxl9.cloudfront.net/" />
78-
19+
<rule from="^http:" to="https:" />
7920
</ruleset>
80-
<!-- Rule generated by HTTPS Finder 0.77 -->

src/chrome/content/rules/Consumer_Reports.com-falsemixed.xml

Lines changed: 0 additions & 22 deletions
This file was deleted.

src/chrome/content/rules/RightNow-clients.xml

Lines changed: 0 additions & 16 deletions
This file was deleted.

0 commit comments

Comments
 (0)