Added "dai.DeviceInfo.desc" API compatibility

themarpe · themarpe · commit db4f7ccaadf9 · 2022-06-06T17:46:58.000+02:00
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -131,7 +131,7 @@ else()
     endif()
     message(STATUS "Mypy available, creating and checking stubs. Running with generate_stubs.py ${TARGET_NAME} ${bindings_directory}")
     add_custom_command(TARGET ${TARGET_NAME} POST_BUILD COMMAND
-        ${CMAKE_COMMAND} -E env 
+        ${CMAKE_COMMAND} -E env
         # PATH (dlls)
         "PATH=${HUNTER_INSTALL_PREFIX}/bin${SYS_PATH_SEPARATOR}$ENV{PATH}"
         # Python path (to find compiled module)
diff --git a/depthai-core b/depthai-core
@@ -1 +1 @@
-Subproject commit 5d7f8afea0a3346acbfa08ae47ee787c6eaa296c
+Subproject commit ce8b527be57485a5d252a87f8284f55d2a914e9e
diff --git a/src/XLinkBindings.cpp b/src/XLinkBindings.cpp
@@ -1,10 +1,13 @@
 #include "XLinkBindings.hpp"
 
+// std
+#include <cmath>
+#include <cstring>
+
+// depthai
 #include "depthai/xlink/XLinkConnection.hpp"
 #include "depthai/xlink/XLinkStream.hpp"
 
-#include <cmath>
-#include <cstring>
 
 void XLinkBindings::bind(pybind11::module &m, void *pCallstack)
 {
@@ -60,6 +63,16 @@ void XLinkBindings::bind(pybind11::module &m, void *pCallstack)
         .def_readwrite("platform", &DeviceInfo::platform)
         .def_readwrite("status", &DeviceInfo::status)
         .def("__repr__", &DeviceInfo::toString)
+        // deprecated
+        .def_property("desc", [](py::object& self) {
+            // Issue an deprecation warning
+            PyErr_WarnEx(PyExc_DeprecationWarning, "desc field is deprecated, use name/mxid and others instead.", 1);
+            return self;
+        },[](DeviceInfo& i, DeviceInfo di){
+            // Issue an deprecation warning
+            PyErr_WarnEx(PyExc_DeprecationWarning, "desc field is deprecated, use name/mxid and others instead.", 1);
+            i = di;
+        })
         ;
 
     deviceDesc
