fix: Streamable HTTP Accept negotiation handling#3153
Draft
dchou1618 wants to merge 3 commits into
Draft
Conversation
resolve coverage error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3154
This change fixes a protocol-handling issue in the SDK’s Streamable HTTP transport.
Some clients send
Acceptheaders that includeq=0entries for unsupported media types. Previously, the server could still treat those values as acceptable, even though RFC 7231 specifies thatq=0means “not acceptable.” This patch correctly parsesAcceptheader quality values and rejects media types withq=0as expected.Motivation and Context
The previous logic only looked for the presence of supported media types in the
Acceptheader and did not honor quality values. As a result, clients could be accepted even when they explicitly declared that a response type was unacceptable. This change makes negotiation more standards-compliant and prevents mismatches between client intent and server behavior.How Has This Been Tested?
I added regression tests covering:
Acceptheader handling withq=0Types of changes
Checklist
Additional context
The change is implemented in
src/mcp/server/streamable_http.py, and regression coverage was added intests/shared/test_streamable_http.py.