Fix 404 links in v1 README to renamed example files#2822
Open
jerome3o-anthropic wants to merge 1 commit into
Open
Fix 404 links in v1 README to renamed example files#2822jerome3o-anthropic wants to merge 1 commit into
jerome3o-anthropic wants to merge 1 commit into
Conversation
The v1 README (frozen on main) links to examples/snippets/servers/ fastmcp_quickstart.py and examples/fastmcp/icons_demo.py on the main branch, but those files were renamed there as part of the FastMCP -> MCPServer rename, so both links now 404. Point them at the v1.x branch, where the files still exist and match the documented v1 API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The v1
README.md(frozen onmainuntil v2 ships) links to two example files on themainbranch that were renamed as part of theFastMCP→MCPServerrename, so both links now 404:examples/snippets/servers/fastmcp_quickstart.py(linked directly under the Quickstart)examples/fastmcp/icons_demo.pyThis points both links at the
v1.xbranch instead, where the files still exist and match the v1 API the README documents.No content changes to the frozen v1 docs — links only (committed with
SKIP=readme-v1-frozen).Verification
Checked every
blob/mainlink inREADME.mdagainst files onmain— these were the only two missing. Confirmed both paths exist onv1.xviagit ls-tree origin/v1.x.