Add stopgap to prevent transcript click from firing twice

terrill · terrill · commit c7d6566b60b7 · 2017-10-01T13:25:30.000-07:00
diff --git a/build/ableplayer.dist.js b/build/ableplayer.dist.js
@@ -9257,7 +9257,16 @@
         var spanStart = parseFloat($(this).attr('data-start'));
         // Add a tiny amount so that we're inside the span.
         spanStart += .01;
-        thisObj.seekTo(spanStart);
+        // Each click within the transcript triggers two click events (not sure why)
+        // this.seekingFromTranscript is a stopgab to prevent two calls to SeekTo()
+        if (!this.seekingFromTranscript) {
+          this.seekingFromTranscript = true;
+          thisObj.seekTo(spanStart);
+        }
+        else {
+          // don't seek a second time, but do reset var
+          thisObj.seekingFromTranscript = false;
+        }
       });
     }
   };
diff --git a/build/ableplayer.js b/build/ableplayer.js
@@ -9257,7 +9257,16 @@ console.log('resizeYouTubePlayer at POS Y1');
         var spanStart = parseFloat($(this).attr('data-start'));
         // Add a tiny amount so that we're inside the span.
         spanStart += .01;
-        thisObj.seekTo(spanStart);
+        // Each click within the transcript triggers two click events (not sure why)
+        // this.seekingFromTranscript is a stopgab to prevent two calls to SeekTo()
+        if (!this.seekingFromTranscript) {
+          this.seekingFromTranscript = true;
+          thisObj.seekTo(spanStart);
+        }
+        else {
+          // don't seek a second time, but do reset var
+          thisObj.seekingFromTranscript = false;
+        }
       });
     }
   };
diff --git a/build/ableplayer.min.css b/build/ableplayer.min.css
diff --git a/build/ableplayer.min.js b/build/ableplayer.min.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ableplayer",
-  "version": "3.0.28",
+  "version": "3.0.29",
   "description": "fully accessible HTML5 media player",
   "homepage": "http://ableplayer.github.io/ableplayer",
   "bugs": "https://github.com/ableplayer/ableplayer/issues",
diff --git a/scripts/transcript.js b/scripts/transcript.js
@@ -216,7 +216,16 @@
         var spanStart = parseFloat($(this).attr('data-start'));
         // Add a tiny amount so that we're inside the span.
         spanStart += .01;
-        thisObj.seekTo(spanStart);
+        // Each click within the transcript triggers two click events (not sure why)
+        // this.seekingFromTranscript is a stopgab to prevent two calls to SeekTo()
+        if (!this.seekingFromTranscript) {
+          this.seekingFromTranscript = true;
+          thisObj.seekTo(spanStart);
+        }
+        else {
+          // don't seek a second time, but do reset var
+          thisObj.seekingFromTranscript = false;
+        }
       });
     }
   };

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "ableplayer",`
`3`		`- "version": "3.0.28",`
	`3`	`+ "version": "3.0.29",`
`4`	`4`	`"description": "fully accessible HTML5 media player",`
`5`	`5`	`"homepage": "http://ableplayer.github.io/ableplayer",`
`6`	`6`	`"bugs": "https://github.com/ableplayer/ableplayer/issues",`