Skip to content

Commit 1dafdd4

Browse files
committed
Fix bug in transcript language selector
1 parent c942230 commit 1dafdd4

6 files changed

Lines changed: 26 additions & 8 deletions

File tree

build/ableplayer.dist.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8783,7 +8783,13 @@
87838783

87848784
if (typeof this.$transcriptLanguageSelect !== 'undefined') {
87858785

8786-
this.$transcriptLanguageSelect.change(function () {
8786+
this.$transcriptLanguageSelect.on('click mousedown',function (event) {
8787+
// execute default behavior
8788+
// prevent propagation of mouse event to toolbar or window
8789+
event.stopPropagation();
8790+
});
8791+
8792+
this.$transcriptLanguageSelect.on('change',function () {
87878793

87888794
var language = thisObj.$transcriptLanguageSelect.val();
87898795

build/ableplayer.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8783,7 +8783,13 @@
87838783

87848784
if (typeof this.$transcriptLanguageSelect !== 'undefined') {
87858785

8786-
this.$transcriptLanguageSelect.change(function () {
8786+
this.$transcriptLanguageSelect.on('click mousedown',function (event) {
8787+
// execute default behavior
8788+
// prevent propagation of mouse event to toolbar or window
8789+
event.stopPropagation();
8790+
});
8791+
8792+
this.$transcriptLanguageSelect.on('change',function () {
87878793

87888794
var language = thisObj.$transcriptLanguageSelect.val();
87898795

build/ableplayer.min.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

build/ableplayer.min.js

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "ableplayer",
3-
"version": "2.3.70",
3+
"version": "2.3.71",
44
"description": "fully accessible HTML5 media player",
55
"homepage": "http://ableplayer.github.io/ableplayer",
66
"bugs": "https://github.com/ableplayer/ableplayer/issues",

scripts/transcript.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,13 @@
8282

8383
if (typeof this.$transcriptLanguageSelect !== 'undefined') {
8484

85-
this.$transcriptLanguageSelect.change(function () {
85+
this.$transcriptLanguageSelect.on('click mousedown',function (event) {
86+
// execute default behavior
87+
// prevent propagation of mouse event to toolbar or window
88+
event.stopPropagation();
89+
});
90+
91+
this.$transcriptLanguageSelect.on('change',function () {
8692

8793
var language = thisObj.$transcriptLanguageSelect.val();
8894

0 commit comments

Comments
 (0)