fix: disable self signed jwt (googleapis#1566)

arithmetic1728 · web-flow · commit 623a71e73d33 · 2021-10-12T20:08:17.000Z
disable self signed jwt since apiary clients mixed cloud and non-cloud apis.

To enable self signed jwt, users can set `always_use_jwt_access` to True in `build` method.
diff --git a/googleapiclient/discovery.py b/googleapiclient/discovery.py
@@ -189,7 +189,7 @@ def build(
     adc_key_path=None,
     num_retries=1,
     static_discovery=None,
-    always_use_jwt_access=True,
+    always_use_jwt_access=False,
 ):
     """Construct a Resource for interacting with an API.
 
@@ -447,7 +447,7 @@ def build_from_document(
     client_options=None,
     adc_cert_path=None,
     adc_key_path=None,
-    always_use_jwt_access=True,
+    always_use_jwt_access=False,
 ):
     """Create a Resource for interacting with an API.
 
diff --git a/tests/test_discovery.py b/tests/test_discovery.py
@@ -695,6 +695,7 @@ def test_self_signed_jwt_enabled(self):
             build_from_document(
                 discovery,
                 credentials=creds,
+                always_use_jwt_access=True,
             )
             _create_self_signed_jwt.assert_called_with("https://logging.googleapis.com/")
 
@@ -708,7 +709,6 @@ def test_self_signed_jwt_disabled(self):
             build_from_document(
                 discovery,
                 credentials=creds,
-                always_use_jwt_access=False,
             )
             _create_self_signed_jwt.assert_not_called()
 

Original file line number	Diff line number	Diff line change
`@@ -695,6 +695,7 @@ def test_self_signed_jwt_enabled(self):`
`695`	`695`	`build_from_document(`
`696`	`696`	`discovery,`
`697`	`697`	`credentials=creds,`
	`698`	`+ always_use_jwt_access=True,`
`698`	`699`	`)`
`699`	`700`	`_create_self_signed_jwt.assert_called_with("https://logging.googleapis.com/")`
`700`	`701`
`@@ -708,7 +709,6 @@ def test_self_signed_jwt_disabled(self):`
`708`	`709`	`build_from_document(`
`709`	`710`	`discovery,`
`710`	`711`	`credentials=creds,`
`711`		`- always_use_jwt_access=False,`
`712`	`712`	`)`
`713`	`713`	`_create_self_signed_jwt.assert_not_called()`
`714`	`714`