pythongh-146245: Fix reference and buffer leaks via audit hook in socket module (pythonGH-146248)

aisk · miss-islington · commit c64d830b28ba · 2026-03-22T11:29:46.000Z
(cherry picked from commit c30fae4) Co-authored-by: AN Long <aisk@users.noreply.github.com>
diff --git a/Misc/NEWS.d/next/Core_and_Builtins/2026-03-21-08-48-25.gh-issue-146245.cqM3_4.rst b/Misc/NEWS.d/next/Core_and_Builtins/2026-03-21-08-48-25.gh-issue-146245.cqM3_4.rst
@@ -0,0 +1 @@
+Fixed reference leaks in :mod:`socket` when audit hooks raise exceptions in :func:`socket.getaddrinfo` and :meth:`!socket.sendto`.
diff --git a/Modules/socketmodule.c b/Modules/socketmodule.c
@@ -4582,6 +4582,7 @@ sock_sendto(PySocketSockObject *s, PyObject *args)
     }
 
     if (PySys_Audit("socket.sendto", "OO", s, addro) < 0) {
+        PyBuffer_Release(&pbuf);
         return NULL;
     }
 
@@ -6801,7 +6802,7 @@ socket_getaddrinfo(PyObject *self, PyObject *args, PyObject* kwargs)
 
     if (PySys_Audit("socket.getaddrinfo", "OOiii",
                     hobj, pobj, family, socktype, protocol) < 0) {
-        return NULL;
+        goto err;
     }
 
     memset(&hints, 0, sizeof(hints));

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Fixed reference leaks in :mod:`socket` when audit hooks raise exceptions in :func:`socket.getaddrinfo` and :meth:`!socket.sendto`.
Original file line number	Diff line number	Diff line change
`@@ -4582,6 +4582,7 @@ sock_sendto(PySocketSockObject s, PyObject args)`
`4582`	`4582`	`}`
`4583`	`4583`
`4584`	`4584`	`if (PySys_Audit("socket.sendto", "OO", s, addro) < 0) {`
	`4585`	`+ PyBuffer_Release(&pbuf);`
`4585`	`4586`	`return NULL;`
`4586`	`4587`	`}`
`4587`	`4588`
`@@ -6801,7 +6802,7 @@ socket_getaddrinfo(PyObject self, PyObject args, PyObject* kwargs)`
`6801`	`6802`
`6802`	`6803`	`if (PySys_Audit("socket.getaddrinfo", "OOiii",`
`6803`	`6804`	`hobj, pobj, family, socktype, protocol) < 0) {`
`6804`		`- return NULL;`
	`6805`	`+ goto err;`
`6805`	`6806`	`}`
`6806`	`6807`
`6807`	`6808`	`memset(&hints, 0, sizeof(hints));`