Skip to content

Commit 37c5a32

Browse files
pablogsalmiss-islington
pablogsal
authored and
miss-islington
committed
pythongh-91048: Add better error messages for remote debugging for CI builds (pythonGH-134682)
(cherry picked from commit 0909d6d) Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
1 parent 6c917cb commit 37c5a32

8 files changed

Lines changed: 540 additions & 129 deletions

‎Include/internal/pycore_global_objects_fini_generated.h‎

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎Include/internal/pycore_global_strings.h‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -385,6 +385,7 @@ struct _Py_global_strings {
385385
STRUCT_FOR_ID(data)
386386
STRUCT_FOR_ID(database)
387387
STRUCT_FOR_ID(day)
388+
STRUCT_FOR_ID(debug)
388389
STRUCT_FOR_ID(decode)
389390
STRUCT_FOR_ID(decoder)
390391
STRUCT_FOR_ID(default)

‎Include/internal/pycore_runtime_init_generated.h‎

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎Include/internal/pycore_unicodeobject_generated.h‎

Lines changed: 4 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎Lib/test/test_external_inspection.py‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,17 +34,17 @@ def _make_test_script(script_dir, script_basename, source):
3434

3535

3636
def get_stack_trace(pid):
37-
unwinder = RemoteUnwinder(pid, all_threads=True)
37+
unwinder = RemoteUnwinder(pid, all_threads=True, debug=True)
3838
return unwinder.get_stack_trace()
3939

4040

4141
def get_async_stack_trace(pid):
42-
unwinder = RemoteUnwinder(pid)
42+
unwinder = RemoteUnwinder(pid, debug=True)
4343
return unwinder.get_async_stack_trace()
4444

4545

4646
def get_all_awaited_by(pid):
47-
unwinder = RemoteUnwinder(pid)
47+
unwinder = RemoteUnwinder(pid, debug=True)
4848
return unwinder.get_all_awaited_by()
4949

5050

0 commit comments

Comments
 (0)