make tests compatible with Node.js 12 (#3304)

silverwind · alexlamsl · commit 9aae4f2424b7 · 2019-03-13T04:55:04.000+08:00
In Node.js 12, the formatting of console arguments will change slightly. Previously, a string other than the first argument was formatted using single quotes if the first argument was non-string. Now, quotes are never added regardless of position of a string argument. To make test compatible in all Node.js versions, I work around by ensuring the first argument to console.log is a string which prevents the quotes from being added on older versions of Node.js. Ref: nodejs/node#23162
diff --git a/test/compress/evaluate.js b/test/compress/evaluate.js
@@ -1245,12 +1245,12 @@ self_comparison_1: {
     }
     input: {
         var o = { n: NaN };
-        console.log(o.n == o.n, o.n === o.n, o.n != o.n, o.n !== o.n, typeof o.n);
+        console.log(typeof o.n, o.n == o.n, o.n === o.n, o.n != o.n, o.n !== o.n);
     }
     expect: {
-        console.log(false, false, true, true, "number");
+        console.log("number", false, false, true, true);
     }
-    expect_stdout: "false false true true 'number'"
+    expect_stdout: "number false false true true"
 }
 
 self_comparison_2: {
@@ -1265,12 +1265,12 @@ self_comparison_2: {
     }
     input: {
         var o = { n: NaN };
-        console.log(o.n == o.n, o.n === o.n, o.n != o.n, o.n !== o.n, typeof o.n);
+        console.log(typeof o.n, o.n == o.n, o.n === o.n, o.n != o.n, o.n !== o.n);
     }
     expect: {
-        console.log(false, false, true, true, "number");
+        console.log("number", false, false, true, true);
     }
-    expect_stdout: "false false true true 'number'"
+    expect_stdout: "number false false true true"
 }
 
 issue_2535_1: {
diff --git a/test/compress/reduce_vars.js b/test/compress/reduce_vars.js
@@ -2740,18 +2740,18 @@ issue_1814_2: {
         !function() {
             var b = a + 1;
             !function(a) {
-                console.log(a++, b);
+                console.log(b, a++);
             }(0);
         }();
     }
     expect: {
         !function() {
             !function(a) {
-                console.log(a++, "321");
+                console.log("321", a++);
             }(0);
         }();
     }
-    expect_stdout: "0 '321'"
+    expect_stdout: "321 0"
 }
 
 try_abort: {

Original file line number	Diff line number	Diff line change
`@@ -1245,12 +1245,12 @@ self_comparison_1: {`
`1245`	`1245`	`}`
`1246`	`1246`	`input: {`
`1247`	`1247`	`var o = { n: NaN };`
`1248`		`- console.log(o.n == o.n, o.n === o.n, o.n != o.n, o.n !== o.n, typeof o.n);`
	`1248`	`+ console.log(typeof o.n, o.n == o.n, o.n === o.n, o.n != o.n, o.n !== o.n);`
`1249`	`1249`	`}`
`1250`	`1250`	`expect: {`
`1251`		`- console.log(false, false, true, true, "number");`
	`1251`	`+ console.log("number", false, false, true, true);`
`1252`	`1252`	`}`
`1253`		`- expect_stdout: "false false true true 'number'"`
	`1253`	`+ expect_stdout: "number false false true true"`
`1254`	`1254`	`}`
`1255`	`1255`
`1256`	`1256`	`self_comparison_2: {`
`@@ -1265,12 +1265,12 @@ self_comparison_2: {`
`1265`	`1265`	`}`
`1266`	`1266`	`input: {`
`1267`	`1267`	`var o = { n: NaN };`
`1268`		`- console.log(o.n == o.n, o.n === o.n, o.n != o.n, o.n !== o.n, typeof o.n);`
	`1268`	`+ console.log(typeof o.n, o.n == o.n, o.n === o.n, o.n != o.n, o.n !== o.n);`
`1269`	`1269`	`}`
`1270`	`1270`	`expect: {`
`1271`		`- console.log(false, false, true, true, "number");`
	`1271`	`+ console.log("number", false, false, true, true);`
`1272`	`1272`	`}`
`1273`		`- expect_stdout: "false false true true 'number'"`
	`1273`	`+ expect_stdout: "number false false true true"`
`1274`	`1274`	`}`
`1275`	`1275`
`1276`	`1276`	`issue_2535_1: {`