Modification of the $timout.cancel in clearTimout to allow e2e test. Start writing e2e tests but sadly they are not functionnals yet.

ychartois · ychartois · commit 570fa517b671 · 2013-07-14T18:56:19.000+02:00
diff --git a/app/js/timer.js b/app/js/timer.js
@@ -31,7 +31,7 @@ angular.module('timer', [])
 
                 function resetTimeout() {
                     if ($scope.timeoutId) {
-                        $timeout.cancel($scope.timeoutId);
+                        clearTimeout($scope.timeoutId);
                     }
                 }
 
@@ -49,7 +49,7 @@ angular.module('timer', [])
 
                 $scope.stop = $element[0].stop = function () {
                     $scope.stoppedTime = new Date();
-                    $timeout.cancel($scope.timeoutId);
+                    clearTimeout($scope.timeoutId);
                     $scope.timeoutId = null;
                 };
 
@@ -80,6 +80,10 @@ angular.module('timer', [])
                         tick();
                         $scope.$apply();
                     }, $scope.interval);
+//                    $scope.timeoutId = $timeout(function() {
+//                        tick();
+//                        //$scope.$apply();
+//                    }, $scope.interval);
 
                     $scope.$emit('timer-tick', {timeoutId: $scope.timeoutId, millis: $scope.millis});
                 };
diff --git a/config/karma-e2e.conf.js b/config/karma-e2e.conf.js
@@ -7,14 +7,14 @@ files = [
   'test/e2e/**/*.js'
 ];
 
-autoWatch = false;
+autoWatch = true;
 
-browsers = ['Chrome'];
+browsers = ['Firefox'];
 
-singleRun = true;
+singleRun = false;
 
 proxies = {
-  '/': 'http://localhost:8000/'
+  '/': 'http://localhost:8383/'
 };
 
 junitReporter = {
diff --git a/examples.html b/examples.html
@@ -249,7 +249,7 @@ <h3>AngularJS - Polling Timers</h3>
             };
 
             $scope.$on('timer-tick', function (event, args) {
-                $scope.timerConsole += $scope.timerType  + ' - event.name = '+ event.name + ', timeoutId = ' + args.timeoutId.$$timeoutId + ', millis = ' + args.millis +'\n';
+                $scope.timerConsole += $scope.timerType  + ' - event.name = '+ event.name + ', timeoutId = ' + args.timeoutId + ', millis = ' + args.millis +'\n';
             });
         }
 
diff --git a/examples/angularjs-polling-timer.html b/examples/angularjs-polling-timer.html
@@ -23,7 +23,7 @@
             };
 
             $scope.$on('timer-tick', function (event, args) {
-                $scope.timerConsole += $scope.timerType  + ' - event.name = '+ event.name + ', timeoutId = ' + args.timeoutId.$$timeoutId + ', millis = ' + args.millis +'\n';
+                $scope.timerConsole += $scope.timerType  + ' - event.name = '+ event.name + ', timeoutId = ' + args.timeoutId + ', millis = ' + args.millis +'\n';
             });
         }
 
diff --git a/scripts/libpeerconnection.log b/scripts/libpeerconnection.log
diff --git a/test/e2e/scenarios.js b/test/e2e/scenarios.js
@@ -5,13 +5,23 @@
 describe('timer directive', function() {
 
   beforeEach(function() {
-    browser().navigateTo('../../index.html');
+      browser().navigateTo('angular-timer/index.html');
   });
 
-  it('Simple timer', function() {
-    sleep(2);
-    var basicExample = angular.element('#timer1');
-    console.log('######## basicExample = ', basicExample.html());
+  it('should stop when user click on stop button [Simple Timer]', function() {
+      sleep(1);
+      element('#basic-timer button:last-child').click();
+      var oldValue = element('#basic-timer span').text();
+      sleep(1);   
+      expect( element('#basic-timer span').text() ).toBe( oldValue );
+  });
+  
+  it('should be reset when user click on start button again [Simple Timer]', function() {
+      sleep(1);
+      var oldValue = element('#basic-timer span').text();
+      element('#basic-timer button:nth-child(3)').click();
+      element('#basic-timer button:last-child').click();
+      expect( element('#basic-timer span').text() ).toBeLessThan( oldValue );
   });
 
 });

Original file line number	Diff line number	Diff line change
`@@ -249,7 +249,7 @@ <h3>AngularJS - Polling Timers</h3>`
`249`	`249`	`};`
`250`	`250`
`251`	`251`	`$scope.$on('timer-tick', function (event, args) {`
`252`		`- $scope.timerConsole += $scope.timerType + ' - event.name = '+ event.name + ', timeoutId = ' + args.timeoutId.$$timeoutId + ', millis = ' + args.millis +'\n';`
	`252`	`+ $scope.timerConsole += $scope.timerType + ' - event.name = '+ event.name + ', timeoutId = ' + args.timeoutId + ', millis = ' + args.millis +'\n';`
`253`	`253`	`});`
`254`	`254`	`}`
`255`	`255`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@`
`23`	`23`	`};`
`24`	`24`
`25`	`25`	`$scope.$on('timer-tick', function (event, args) {`
`26`		`- $scope.timerConsole += $scope.timerType + ' - event.name = '+ event.name + ', timeoutId = ' + args.timeoutId.$$timeoutId + ', millis = ' + args.millis +'\n';`
	`26`	`+ $scope.timerConsole += $scope.timerType + ' - event.name = '+ event.name + ', timeoutId = ' + args.timeoutId + ', millis = ' + args.millis +'\n';`
`27`	`27`	`});`
`28`	`28`	`}`
`29`	`29`