Skip to content

Commit dd911cd

Browse files
committed
Merge pull request #1 from minsh/minor-fix
minor fix
2 parents efbdb8c + 9d6878b commit dd911cd

2 files changed

Lines changed: 12 additions & 12 deletions

File tree

angular-awesome-error.js

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -23,47 +23,47 @@
2323
target: '='
2424
},
2525
template: '<div> \
26-
<div ng-show="showerr"> \
26+
<div ng-show="showErr"> \
2727
<div class="alert alert-error fade in"> \
2828
{{showMessage}} \
2929
</div> \
3030
</div> \
31-
<div ng-show="showsucc"> \
31+
<div ng-show="showSucc"> \
3232
<div class="alert fade in alert-success"> \
3333
{{showMessage}} \
3434
</div> \
3535
</div> \
3636
</div>',
3737
link: function(scope) {
3838

39-
scope.messages = {};
39+
scope.messageMap = {};
4040

4141
var _showMsg = function(val, args, target, str) {
4242
if (scope.target === target) {
43-
scope.showMessage = scope.messages[str];
44-
if (scope.showMessage === "") {
45-
scope.showMessage = scope.messages["Undefined"];
43+
if (!str) {
44+
str = 'Undefined';
4645
}
46+
scope.showMessage = scope.messageMap[str];
4747
if (args.name.indexOf('error') !== -1) {
48-
scope.showerr = val;
48+
scope.showErr = val;
4949
} else {
50-
scope.showsucc = val;
50+
scope.showSucc = val;
5151
}
5252
}
5353
};
5454

5555
/* fetching data present in 'errors-list.json' file */
5656
list.success(function(data) {
57-
scope.messages = data;
57+
scope.messageMap = data;
5858
});
5959

6060
scope.$on('show error', function (args, target, err) {
6161
_showMsg(true, args, target, err);
6262
});
6363

6464
scope.$on('hide all', function(args, target) {
65-
scope.showerr = false;
66-
scope.showsucc = false;
65+
scope.showErr = false;
66+
scope.showSucc = false;
6767
});
6868

6969
scope.$on('hide error', function (args, target) {

bower.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "angular-errors-directive",
3-
"version": "0.2.1",
3+
"version": "0.2.2",
44
"main": "angular-awesome-error.js",
55
"ignore": [
66
"**/.*",

0 commit comments

Comments
 (0)