modify allocate handler to no longer return anything

hjwp · hjwp · commit 344cf81c110c · 2024-03-01T15:05:35.000Z
diff --git a/src/allocation/service_layer/handlers.py b/src/allocation/service_layer/handlers.py
@@ -28,15 +28,14 @@ def add_batch(
 def allocate(
     cmd: commands.Allocate,
     uow: unit_of_work.AbstractUnitOfWork,
-) -> str:
+):
     line = OrderLine(cmd.orderid, cmd.sku, cmd.qty)
     with uow:
         product = uow.products.get(sku=line.sku)
         if product is None:
             raise InvalidSku(f"Invalid sku {line.sku}")
-        batchref = product.allocate(line)
+        product.allocate(line)
         uow.commit()
-        return batchref
 
 
 def change_batch_quantity(
diff --git a/tests/unit/test_handlers.py b/tests/unit/test_handlers.py
@@ -65,10 +65,7 @@ def test_allocates(self):
         messagebus.handle(
             commands.CreateBatch("batch1", "COMPLICATED-LAMP", 100, None), uow
         )
-        results = messagebus.handle(
-            commands.Allocate("o1", "COMPLICATED-LAMP", 10), uow
-        )
-        assert results.pop(0) == "batch1"
+        messagebus.handle(commands.Allocate("o1", "COMPLICATED-LAMP", 10), uow)
         [batch] = uow.products.get("COMPLICATED-LAMP").batches
         assert batch.available_quantity == 90
 
