From 397e2cd277f79603a8422f03e4e4677c710b9f75 Mon Sep 17 00:00:00 2001 From: Don Jayamanne Date: Thu, 7 Nov 2019 16:25:15 -0800 Subject: [PATCH] Update node to 12.4.0 --- .nvmrc | 2 +- CONTRIBUTING.md | 2 +- build/ci/templates/globals.yml | 2 +- news/3 Code Health/8453.md | 1 + 4 files changed, 4 insertions(+), 3 deletions(-) create mode 100644 news/3 Code Health/8453.md diff --git a/.nvmrc b/.nvmrc index 6507a3c33300..e23e7f3a97dc 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -v10.11.0 +v12.4.0 diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index ed910f9fdbe4..71bb3f4bb3e8 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -19,7 +19,7 @@ ### Prerequisites -1. [Node.js](https://nodejs.org/) 10.x +1. [Node.js](https://nodejs.org/) 12.x 1. [Python](https://www.python.org/) 2.7 or later 1. Windows, macOS, or Linux 1. [Visual Studio Code](https://code.visualstudio.com/) diff --git a/build/ci/templates/globals.yml b/build/ci/templates/globals.yml index b63ac0c0627c..1303ba0bc8e6 100644 --- a/build/ci/templates/globals.yml +++ b/build/ci/templates/globals.yml @@ -1,6 +1,6 @@ variables: PythonVersion: '3.7' # Always use latest version. - NodeVersion: '10.11.0' # Check version of node used in VS Code. + NodeVersion: '12.4.0' # Check version of node used in VS Code. NpmVersion: '6.13.4' MOCHA_FILE: '$(Build.ArtifactStagingDirectory)/test-junit.xml' # All test files will write their JUnit xml output to this file, clobbering the last time it was written. MOCHA_REPORTER_JUNIT: true # Use the mocha-multi-reporters and send output to both console (spec) and JUnit (mocha-junit-reporter). diff --git a/news/3 Code Health/8453.md b/news/3 Code Health/8453.md new file mode 100644 index 000000000000..a871756823c5 --- /dev/null +++ b/news/3 Code Health/8453.md @@ -0,0 +1 @@ +Update version of node to `12.4.0`.