From 5bbf74bbbdeabc3a7453180c62a6c861104cfb00 Mon Sep 17 00:00:00 2001 From: Yan Pashkovsky Date: Fri, 26 Apr 2019 18:59:14 +0300 Subject: [PATCH 1/3] poetry dev --- src/client/common/installer/poetryInstaller.ts | 2 +- src/test/common/installer/poetryInstaller.unit.test.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/client/common/installer/poetryInstaller.ts b/src/client/common/installer/poetryInstaller.ts index 7b7742e0e35f..75809c11796e 100644 --- a/src/client/common/installer/poetryInstaller.ts +++ b/src/client/common/installer/poetryInstaller.ts @@ -61,7 +61,7 @@ export class PoetryInstaller extends ModuleInstaller implements IModuleInstaller protected async getExecutionInfo(moduleName: string, resource?: Uri): Promise { const execPath = this.configurationService.getSettings(resource).poetryPath; return { - args: ['add', moduleName], + args: ['add', '--dev', moduleName], execPath }; } diff --git a/src/test/common/installer/poetryInstaller.unit.test.ts b/src/test/common/installer/poetryInstaller.unit.test.ts index 6d19bd102eef..4517c4da62b3 100644 --- a/src/test/common/installer/poetryInstaller.unit.test.ts +++ b/src/test/common/installer/poetryInstaller.unit.test.ts @@ -120,6 +120,6 @@ suite('Module Installer - Poetry', () => { const info = await poetryInstaller.getExecutionInfo('something', uri); - assert.deepEqual(info, { args: ['add', 'something'], execPath: 'poetry path' }); + assert.deepEqual(info, { args: ['add', '--dev', 'something'], execPath: 'poetry path' }); }); }); From b9c11ccac5cdf2fd8162e1c0d9633cfc5949edc2 Mon Sep 17 00:00:00 2001 From: Yan Pashkovsky Date: Fri, 26 Apr 2019 19:09:51 +0300 Subject: [PATCH 2/3] add news --- news/2 Fixes/5496.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 news/2 Fixes/5496.md diff --git a/news/2 Fixes/5496.md b/news/2 Fixes/5496.md new file mode 100644 index 000000000000..5d4acb307f49 --- /dev/null +++ b/news/2 Fixes/5496.md @@ -0,0 +1 @@ +Fix poetry dependency adding From 3725e80ba430ffbb4de7d9fa56fa7da0efc67b5c Mon Sep 17 00:00:00 2001 From: Don Jayamanne Date: Mon, 29 Apr 2019 12:51:05 -0700 Subject: [PATCH 3/3] Update news entry --- news/2 Fixes/5496.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/news/2 Fixes/5496.md b/news/2 Fixes/5496.md index 5d4acb307f49..35475ce66ad9 100644 --- a/news/2 Fixes/5496.md +++ b/news/2 Fixes/5496.md @@ -1 +1,2 @@ -Fix poetry dependency adding +Add dev flag to poetry installer. +(thanks [Yan Pashkovsky](https://github.com/Yanpas))