diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 85f5435f0699..2f483e896b61 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -9,7 +9,7 @@ on: - 'release-*' env: - NODE_VERSION: 12.15.0 + NODE_VERSION: 14.18.2 # Force a path with spaces and to test extension works in these scenarios # Unicode characters are causing 2.7 failures so skip that for now. special-working-directory: './path with spaces' diff --git a/.github/workflows/pr-check.yml b/.github/workflows/pr-check.yml index 8a86f92c081e..006d5a5c325c 100644 --- a/.github/workflows/pr-check.yml +++ b/.github/workflows/pr-check.yml @@ -8,7 +8,7 @@ on: - release* env: - NODE_VERSION: 12.15.0 + NODE_VERSION: 14.18.2 PYTHON_VERSION: '3.10' # YML treats 3.10 the number as 3.1, so quotes around 3.10 MOCHA_REPORTER_JUNIT: true # Use the mocha-multi-reporters and send output to both console (spec) and JUnit (mocha-junit-reporter). Also enables a reporter which exits the process running the tests if it haven't already. ARTIFACT_NAME_VSIX: ms-python-insiders-vsix diff --git a/.nvmrc b/.nvmrc index 7124fdc300ae..ca4a60d1b111 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -v12.20.0 +v14.18.2 diff --git a/news/3 Code Health/18148.md b/news/3 Code Health/18148.md new file mode 100644 index 000000000000..ff887fa7b25f --- /dev/null +++ b/news/3 Code Health/18148.md @@ -0,0 +1 @@ +Upgrade to Node 14 LTS (v14.18.2). diff --git a/package-lock.json b/package-lock.json index 50e29463aeb1..80fa7a9e5a67 100644 --- a/package-lock.json +++ b/package-lock.json @@ -61,7 +61,7 @@ "@types/md5": "^2.1.32", "@types/mocha": "^5.2.7", "@types/nock": "^10.0.3", - "@types/node": "^12.19.12", + "@types/node": "^14.18.0", "@types/request": "^2.47.0", "@types/semver": "^5.5.0", "@types/shortid": "^0.0.29", @@ -744,9 +744,9 @@ } }, "node_modules/@types/node": { - "version": "12.19.12", - "resolved": "https://registry.npmjs.org/@types/node/-/node-12.19.12.tgz", - "integrity": "sha512-UwfL2uIU9arX/+/PRcIkT08/iBadGN2z6ExOROA2Dh5mAuWTBj6iJbQX4nekiV5H8cTrEG569LeX+HRco9Cbxw==", + "version": "14.18.0", + "resolved": "https://registry.npmjs.org/@types/node/-/node-14.18.0.tgz", + "integrity": "sha512-0GeIl2kmVMXEnx8tg1SlG6Gg8vkqirrW752KqolYo1PHevhhZN3bhJ67qHj+bQaINhX0Ra3TlWwRvMCd9iEfNQ==", "dev": true }, "node_modules/@types/request": { @@ -17220,9 +17220,9 @@ } }, "@types/node": { - "version": "12.19.12", - "resolved": "https://registry.npmjs.org/@types/node/-/node-12.19.12.tgz", - "integrity": "sha512-UwfL2uIU9arX/+/PRcIkT08/iBadGN2z6ExOROA2Dh5mAuWTBj6iJbQX4nekiV5H8cTrEG569LeX+HRco9Cbxw==", + "version": "14.18.0", + "resolved": "https://registry.npmjs.org/@types/node/-/node-14.18.0.tgz", + "integrity": "sha512-0GeIl2kmVMXEnx8tg1SlG6Gg8vkqirrW752KqolYo1PHevhhZN3bhJ67qHj+bQaINhX0Ra3TlWwRvMCd9iEfNQ==", "dev": true }, "@types/request": { diff --git a/package.json b/package.json index 01231d69b1a3..eda644d69815 100644 --- a/package.json +++ b/package.json @@ -1954,7 +1954,7 @@ "@types/md5": "^2.1.32", "@types/mocha": "^5.2.7", "@types/nock": "^10.0.3", - "@types/node": "^12.19.12", + "@types/node": "^14.18.0", "@types/request": "^2.47.0", "@types/semver": "^5.5.0", "@types/shortid": "^0.0.29", diff --git a/src/client/common/platform/fileSystem.ts b/src/client/common/platform/fileSystem.ts index 9d66887f4c39..8f962b0f776f 100644 --- a/src/client/common/platform/fileSystem.ts +++ b/src/client/common/platform/fileSystem.ts @@ -122,7 +122,7 @@ export class RawFileSystem implements IRawFileSystem { // The "fs-extra" module is effectively equivalent to node's "fs" // module (but is a bit more async-friendly). So we use that // instead of "fs". - fsExtra || fs, + fsExtra || (fs as IRawFSExtra), ); }