From e3fc993ba3dbeef12a87e4e8265a004fce0268d1 Mon Sep 17 00:00:00 2001 From: Kim-Adeline Miguel Date: Wed, 12 Feb 2020 11:46:55 -0800 Subject: [PATCH 01/13] Prep for testing the workflow while working on it --- .github/workflows/ci.yml | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 9a174b3f91f8..c0e5b8617060 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -4,7 +4,7 @@ on: push: branches: # Run the CI workflow only on master for microsoft/vscode-python for now. - - master + - gh-action-* env: PYTHON_VERSION: 3.8 @@ -21,7 +21,7 @@ jobs: python-deps: name: Install Python Requirements runs-on: ubuntu-latest - if: github.repository == 'microsoft/vscode-python' + # if: github.repository == 'microsoft/vscode-python' steps: - name: Checkout uses: actions/checkout@v2 @@ -66,7 +66,7 @@ jobs: js-ts-deps: name: Install npm dependencies runs-on: ubuntu-latest - if: github.repository == 'microsoft/vscode-python' + # if: github.repository == 'microsoft/vscode-python' steps: - name: Checkout uses: actions/checkout@v2 @@ -180,16 +180,16 @@ jobs: name: Tests # The value of runs-on is the OS of the current job (specified in the strategy matrix below) instead of being hardcoded. runs-on: ${{ matrix.os }} - if: github.repository == 'microsoft/vscode-python' + # if: github.repository == 'microsoft/vscode-python' needs: [python-deps, js-ts-deps] strategy: matrix: # We're not running CI on macOS for now because it's one less matrix entry to lower the number of runners used, # macOS runners are expensive, and we assume that Ubuntu is enough to cover the UNIX case. - os: [ubuntu-latest, windows-latest] + os: [ubuntu-latest] # Run the tests on the oldest and most recent versions of Python. - python: [2.7, 3.8] - test-suite: [ts-unit, python-unit, venv, single-workspace, multi-workspace, debugger, functional] + python: [3.8] + test-suite: [ts-unit] steps: - name: Checkout uses: actions/checkout@v2 @@ -358,12 +358,12 @@ jobs: # The value of runs-on is the OS of the current job (specified in the strategy matrix below) instead of being hardcoded. runs-on: ${{ matrix.os }} needs: [build-vsix] - if: github.repository == 'microsoft/vscode-python' + # if: github.repository == 'microsoft/vscode-python' strategy: matrix: # We're not running CI on macOS for now because it's one less matrix entry to lower the number of runners used, # macOS runners are expensive, and we assume that Ubuntu is enough to cover the UNIX case. - os: [ubuntu-latest, windows-latest] + os: [ubuntu-latest] python: [3.8] steps: - name: Checkout From c528b0dd72da74b0b06af9f6df3c695b5909b540 Mon Sep 17 00:00:00 2001 From: Kim-Adeline Miguel Date: Wed, 12 Feb 2020 15:39:55 -0800 Subject: [PATCH 02/13] Don't need any job to test tag pushing --- .github/workflows/ci.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b5fe21d13d04..445e36f1004e 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -22,7 +22,7 @@ jobs: python-deps: name: Install Python Requirements runs-on: ubuntu-latest - # if: github.repository == 'microsoft/vscode-python' + if: github.repository == 'microsoft/vscode-python' steps: - name: Checkout uses: actions/checkout@v2 @@ -67,7 +67,7 @@ jobs: js-ts-deps: name: Install npm dependencies runs-on: ubuntu-latest - # if: github.repository == 'microsoft/vscode-python' + if: github.repository == 'microsoft/vscode-python' steps: - name: Checkout uses: actions/checkout@v2 @@ -181,7 +181,7 @@ jobs: name: Tests # The value of runs-on is the OS of the current job (specified in the strategy matrix below) instead of being hardcoded. runs-on: ${{ matrix.os }} - # if: github.repository == 'microsoft/vscode-python' + if: github.repository == 'microsoft/vscode-python' needs: [python-deps, js-ts-deps] strategy: matrix: @@ -366,7 +366,7 @@ jobs: # The value of runs-on is the OS of the current job (specified in the strategy matrix below) instead of being hardcoded. runs-on: ${{ matrix.os }} needs: [build-vsix] - # if: github.repository == 'microsoft/vscode-python' + if: github.repository == 'microsoft/vscode-python' strategy: matrix: # We're not running CI on macOS for now because it's one less matrix entry to lower the number of runners used, From 7f3dce3a92ac90fece39a49ba4c0e08628a48911 Mon Sep 17 00:00:00 2001 From: Kim-Adeline Miguel Date: Wed, 12 Feb 2020 16:06:40 -0800 Subject: [PATCH 03/13] Alright let's try it --- .github/workflows/ci.yml | 43 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 43 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 445e36f1004e..e24e45710ffe 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -16,6 +16,7 @@ env: ARTIFACT_NAME_VSIX: ms-python-insiders-vsix COVERAGE_REPORTS: tests-coverage-reports TEST_RESULTS_DIRECTORY: . + LKG_TAG: ci-lkg jobs: ### Initialization: retrieve, install and cache dependencies @@ -448,3 +449,45 @@ jobs: with: CODECOV_TOKEN: ${{secrets.CODECOV_TOKEN}} file: ./coverage/cobertura-coverage.xml + + lkg-tag: + # LKG = last known good + name: Tag successful build as LKG + runs-on: ubuntu-latest + # needs: [tests, smoke-tests] + # if: github.repository == 'microsoft/vscode-python' + steps: + - name: Checkout + uses: actions/checkout@v2 + + - name: Delete existing tag + run: | + curl -s -X DELETE https://api.github.com/repos/kimadeline/vscode-python/git/refs/tags/${{env.LKG_TAG}} \ + -H "Authorization: token ${{secrets.GITHUB_TOKEN}}" \ + -d @- << EOF + + # We need to make 2 calls when creating an annotated tag: first create the tag object, and then the tag reference. + # If we wanted to create a lightweight tag we would only need the tag reference. + # See https://developer.github.com/v3/git/tags/#create-a-tag-object + - name: Create a tag object + # Curl syntax explanation: https://stackoverflow.com/a/36778045 + run: curl -s -X POST "https://api.github.com/repos/kimadeline/vscode-python/git/tags"\ + -H "Authorization: token ${{secrets.GITHUB_TOKEN}}" \ + -d @- << EOF + { + "tag": "${{env.LKG_TAG}}", + "message": "Last known good build of vscode-python via the GitHub Action CI workflow", + "object": "$GITHUB_SHA", + "type": "commit" + } + EOF + + - name: Create a tag reference + run: curl -s -X POST "https://api.github.com/repos/kimadeline/vscode-python/git/refs"\ + -H "Authorization: token ${{secrets.GITHUB_TOKEN}}" \ + -d @- << EOF + { + "ref": "refs/tags/${{env.LKG_TAG}}", + "sha": "$GITHUB_SHA", + } + EOF From 63ee6198c226d8f2be3cd863771cc0639bf0e1fa Mon Sep 17 00:00:00 2001 From: Kim-Adeline Miguel Date: Wed, 12 Feb 2020 16:08:49 -0800 Subject: [PATCH 04/13] Forgot the syntax for multiline commands lol --- .github/workflows/ci.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e24e45710ffe..234b12a77925 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -471,7 +471,8 @@ jobs: # See https://developer.github.com/v3/git/tags/#create-a-tag-object - name: Create a tag object # Curl syntax explanation: https://stackoverflow.com/a/36778045 - run: curl -s -X POST "https://api.github.com/repos/kimadeline/vscode-python/git/tags"\ + run: | + curl -s -X POST "https://api.github.com/repos/kimadeline/vscode-python/git/tags"\ -H "Authorization: token ${{secrets.GITHUB_TOKEN}}" \ -d @- << EOF { @@ -483,7 +484,8 @@ jobs: EOF - name: Create a tag reference - run: curl -s -X POST "https://api.github.com/repos/kimadeline/vscode-python/git/refs"\ + run: | + curl -s -X POST "https://api.github.com/repos/kimadeline/vscode-python/git/refs"\ -H "Authorization: token ${{secrets.GITHUB_TOKEN}}" \ -d @- << EOF { From 60a26ab4f464bd807e5ac4b19b551037d0e6e9e0 Mon Sep 17 00:00:00 2001 From: Kim-Adeline Miguel Date: Wed, 12 Feb 2020 16:09:29 -0800 Subject: [PATCH 05/13] Try removing slashes --- .github/workflows/ci.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 234b12a77925..24c9b52595b8 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -472,8 +472,8 @@ jobs: - name: Create a tag object # Curl syntax explanation: https://stackoverflow.com/a/36778045 run: | - curl -s -X POST "https://api.github.com/repos/kimadeline/vscode-python/git/tags"\ - -H "Authorization: token ${{secrets.GITHUB_TOKEN}}" \ + curl -s -X POST "https://api.github.com/repos/kimadeline/vscode-python/git/tags" + -H "Authorization: token ${{secrets.GITHUB_TOKEN}}" -d @- << EOF { "tag": "${{env.LKG_TAG}}", @@ -485,8 +485,8 @@ jobs: - name: Create a tag reference run: | - curl -s -X POST "https://api.github.com/repos/kimadeline/vscode-python/git/refs"\ - -H "Authorization: token ${{secrets.GITHUB_TOKEN}}" \ + curl -s -X POST "https://api.github.com/repos/kimadeline/vscode-python/git/refs" + -H "Authorization: token ${{secrets.GITHUB_TOKEN}}" -d @- << EOF { "ref": "refs/tags/${{env.LKG_TAG}}", From 23a77a05399f779a28049a1fa31be6b227e70216 Mon Sep 17 00:00:00 2001 From: Kim-Adeline Miguel Date: Wed, 12 Feb 2020 16:10:40 -0800 Subject: [PATCH 06/13] Indentation? --- .github/workflows/ci.yml | 40 ++++++++++++++++++++-------------------- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 24c9b52595b8..8038a7b290d9 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -460,7 +460,7 @@ jobs: - name: Checkout uses: actions/checkout@v2 - - name: Delete existing tag + - name: Delete existing tag run: | curl -s -X DELETE https://api.github.com/repos/kimadeline/vscode-python/git/refs/tags/${{env.LKG_TAG}} \ -H "Authorization: token ${{secrets.GITHUB_TOKEN}}" \ @@ -472,24 +472,24 @@ jobs: - name: Create a tag object # Curl syntax explanation: https://stackoverflow.com/a/36778045 run: | - curl -s -X POST "https://api.github.com/repos/kimadeline/vscode-python/git/tags" - -H "Authorization: token ${{secrets.GITHUB_TOKEN}}" - -d @- << EOF - { - "tag": "${{env.LKG_TAG}}", - "message": "Last known good build of vscode-python via the GitHub Action CI workflow", - "object": "$GITHUB_SHA", - "type": "commit" - } - EOF - + curl -s -X POST "https://api.github.com/repos/kimadeline/vscode-python/git/tags" \ + -H "Authorization: token ${{secrets.GITHUB_TOKEN}}" \ + -d @- << EOF + { + "tag": "${{env.LKG_TAG}}", + "message": "Last known good build of vscode-python via the GitHub Action CI workflow", + "object": "$GITHUB_SHA", + "type": "commit" + } + EOF + - name: Create a tag reference run: | - curl -s -X POST "https://api.github.com/repos/kimadeline/vscode-python/git/refs" - -H "Authorization: token ${{secrets.GITHUB_TOKEN}}" - -d @- << EOF - { - "ref": "refs/tags/${{env.LKG_TAG}}", - "sha": "$GITHUB_SHA", - } - EOF + curl -s -X POST "https://api.github.com/repos/kimadeline/vscode-python/git/refs" \ + -H "Authorization: token ${{secrets.GITHUB_TOKEN}}" \ + -d @- << EOF + { + "ref": "refs/tags/${{env.LKG_TAG}}", + "sha": "$GITHUB_SHA", + } + EOF From 4ffe71c1e9b313789cb379e95553ca6969715dd6 Mon Sep 17 00:00:00 2001 From: Kim-Adeline Miguel Date: Wed, 12 Feb 2020 16:12:42 -0800 Subject: [PATCH 07/13] Change the way we refer to the sha --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8038a7b290d9..60ddb4085589 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -478,7 +478,7 @@ jobs: { "tag": "${{env.LKG_TAG}}", "message": "Last known good build of vscode-python via the GitHub Action CI workflow", - "object": "$GITHUB_SHA", + "object": "${{github.sha}}", "type": "commit" } EOF @@ -490,6 +490,6 @@ jobs: -d @- << EOF { "ref": "refs/tags/${{env.LKG_TAG}}", - "sha": "$GITHUB_SHA", + "sha": "${{github.sha}}", } EOF From fbc05d139962e705023ee530a749db3ca6e3612f Mon Sep 17 00:00:00 2001 From: Kim-Adeline Miguel Date: Wed, 12 Feb 2020 16:15:20 -0800 Subject: [PATCH 08/13] Remove unnecessary document pipe --- .github/workflows/ci.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 60ddb4085589..4cd61e038123 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -463,8 +463,7 @@ jobs: - name: Delete existing tag run: | curl -s -X DELETE https://api.github.com/repos/kimadeline/vscode-python/git/refs/tags/${{env.LKG_TAG}} \ - -H "Authorization: token ${{secrets.GITHUB_TOKEN}}" \ - -d @- << EOF + -H "Authorization: token ${{secrets.GITHUB_TOKEN}}" # We need to make 2 calls when creating an annotated tag: first create the tag object, and then the tag reference. # If we wanted to create a lightweight tag we would only need the tag reference. From e6993209008aaaedd3e20fbee4943367b78f7561 Mon Sep 17 00:00:00 2001 From: Kim-Adeline Miguel Date: Wed, 12 Feb 2020 16:17:47 -0800 Subject: [PATCH 09/13] Remove extra comma --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 4cd61e038123..8ee3f89edf8a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -489,6 +489,6 @@ jobs: -d @- << EOF { "ref": "refs/tags/${{env.LKG_TAG}}", - "sha": "${{github.sha}}", + "sha": "${{github.sha}}" } EOF From cab79e8a1913bcfb63802ed4af98f948a10d266c Mon Sep 17 00:00:00 2001 From: Kim-Adeline Miguel Date: Wed, 12 Feb 2020 16:23:21 -0800 Subject: [PATCH 10/13] Delete the tag, i don't want it on my fork lol --- .github/workflows/ci.yml | 48 +++++++++++++++++++--------------------- 1 file changed, 23 insertions(+), 25 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8ee3f89edf8a..187f6cf345ba 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -464,31 +464,29 @@ jobs: run: | curl -s -X DELETE https://api.github.com/repos/kimadeline/vscode-python/git/refs/tags/${{env.LKG_TAG}} \ -H "Authorization: token ${{secrets.GITHUB_TOKEN}}" - # We need to make 2 calls when creating an annotated tag: first create the tag object, and then the tag reference. # If we wanted to create a lightweight tag we would only need the tag reference. # See https://developer.github.com/v3/git/tags/#create-a-tag-object - - name: Create a tag object - # Curl syntax explanation: https://stackoverflow.com/a/36778045 - run: | - curl -s -X POST "https://api.github.com/repos/kimadeline/vscode-python/git/tags" \ - -H "Authorization: token ${{secrets.GITHUB_TOKEN}}" \ - -d @- << EOF - { - "tag": "${{env.LKG_TAG}}", - "message": "Last known good build of vscode-python via the GitHub Action CI workflow", - "object": "${{github.sha}}", - "type": "commit" - } - EOF - - - name: Create a tag reference - run: | - curl -s -X POST "https://api.github.com/repos/kimadeline/vscode-python/git/refs" \ - -H "Authorization: token ${{secrets.GITHUB_TOKEN}}" \ - -d @- << EOF - { - "ref": "refs/tags/${{env.LKG_TAG}}", - "sha": "${{github.sha}}" - } - EOF + # - name: Create a tag object + # # Curl syntax explanation: https://stackoverflow.com/a/36778045 + # run: | + # curl -s -X POST "https://api.github.com/repos/kimadeline/vscode-python/git/tags" \ + # -H "Authorization: token ${{secrets.GITHUB_TOKEN}}" \ + # -d @- << EOF + # { + # "tag": "${{env.LKG_TAG}}", + # "message": "Last known good build of vscode-python via the GitHub Action CI workflow", + # "object": "${{github.sha}}", + # "type": "commit" + # } + # EOF + # - name: Create a tag reference + # run: | + # curl -s -X POST "https://api.github.com/repos/kimadeline/vscode-python/git/refs" \ + # -H "Authorization: token ${{secrets.GITHUB_TOKEN}}" \ + # -d @- << EOF + # { + # "ref": "refs/tags/${{env.LKG_TAG}}", + # "sha": "${{github.sha}}" + # } + # EOF From 905b073d2ee1dc92d567e4d798e5cae6992f66a6 Mon Sep 17 00:00:00 2001 From: Kim-Adeline Miguel Date: Wed, 12 Feb 2020 16:24:29 -0800 Subject: [PATCH 11/13] No need for checkout step --- .github/workflows/ci.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 187f6cf345ba..fe4f392028df 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -457,9 +457,6 @@ jobs: # needs: [tests, smoke-tests] # if: github.repository == 'microsoft/vscode-python' steps: - - name: Checkout - uses: actions/checkout@v2 - - name: Delete existing tag run: | curl -s -X DELETE https://api.github.com/repos/kimadeline/vscode-python/git/refs/tags/${{env.LKG_TAG}} \ From f46c34952943cffe8e116c3351a613eac127257a Mon Sep 17 00:00:00 2001 From: Kim-Adeline Miguel Date: Wed, 12 Feb 2020 16:24:49 -0800 Subject: [PATCH 12/13] Uncomment conditions + run tagging on main repo --- .github/workflows/ci.yml | 54 +++++++++++++++++++++------------------- 1 file changed, 28 insertions(+), 26 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index fe4f392028df..150e00777186 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -454,36 +454,38 @@ jobs: # LKG = last known good name: Tag successful build as LKG runs-on: ubuntu-latest - # needs: [tests, smoke-tests] - # if: github.repository == 'microsoft/vscode-python' + needs: [tests, smoke-tests] + if: github.repository == 'microsoft/vscode-python' steps: - name: Delete existing tag run: | - curl -s -X DELETE https://api.github.com/repos/kimadeline/vscode-python/git/refs/tags/${{env.LKG_TAG}} \ + curl -s -X DELETE https://api.github.com/repos/microsoft/vscode-python/git/refs/tags/${{env.LKG_TAG}} \ -H "Authorization: token ${{secrets.GITHUB_TOKEN}}" + # We need to make 2 calls when creating an annotated tag: first create the tag object, and then the tag reference. # If we wanted to create a lightweight tag we would only need the tag reference. # See https://developer.github.com/v3/git/tags/#create-a-tag-object - # - name: Create a tag object - # # Curl syntax explanation: https://stackoverflow.com/a/36778045 - # run: | - # curl -s -X POST "https://api.github.com/repos/kimadeline/vscode-python/git/tags" \ - # -H "Authorization: token ${{secrets.GITHUB_TOKEN}}" \ - # -d @- << EOF - # { - # "tag": "${{env.LKG_TAG}}", - # "message": "Last known good build of vscode-python via the GitHub Action CI workflow", - # "object": "${{github.sha}}", - # "type": "commit" - # } - # EOF - # - name: Create a tag reference - # run: | - # curl -s -X POST "https://api.github.com/repos/kimadeline/vscode-python/git/refs" \ - # -H "Authorization: token ${{secrets.GITHUB_TOKEN}}" \ - # -d @- << EOF - # { - # "ref": "refs/tags/${{env.LKG_TAG}}", - # "sha": "${{github.sha}}" - # } - # EOF + - name: Create a tag object + # Curl syntax explanation: https://stackoverflow.com/a/36778045 + run: | + curl -s -X POST "https://api.github.com/repos/microsoft/vscode-python/git/tags" \ + -H "Authorization: token ${{secrets.GITHUB_TOKEN}}" \ + -d @- << EOF + { + "tag": "${{env.LKG_TAG}}", + "message": "Last known good build of vscode-python via the GitHub Action CI workflow", + "object": "${{github.sha}}", + "type": "commit" + } + EOF + + - name: Create a tag reference + run: | + curl -s -X POST "https://api.github.com/repos/microsoft/vscode-python/git/refs" \ + -H "Authorization: token ${{secrets.GITHUB_TOKEN}}" \ + -d @- << EOF + { + "ref": "refs/tags/${{env.LKG_TAG}}", + "sha": "${{github.sha}}" + } + EOF From 60478814e7339d7c76c5878175cd2abab886b91e Mon Sep 17 00:00:00 2001 From: Kim-Adeline Miguel Date: Wed, 12 Feb 2020 16:27:45 -0800 Subject: [PATCH 13/13] Forgot to undo testing changes, clarify comments --- .github/workflows/ci.yml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 150e00777186..51fe9debb8b0 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -4,7 +4,7 @@ on: push: branches: # Run the CI workflow only on master for microsoft/vscode-python for now. - - gh-action-* + - master env: PYTHON_VERSION: 3.8 @@ -188,10 +188,10 @@ jobs: matrix: # We're not running CI on macOS for now because it's one less matrix entry to lower the number of runners used, # macOS runners are expensive, and we assume that Ubuntu is enough to cover the UNIX case. - os: [ubuntu-latest] + os: [ubuntu-latest, windows-latest] # Run the tests on the oldest and most recent versions of Python. - python: [3.8] - test-suite: [ts-unit] + python: [2.7, 3.8] + test-suite: [ts-unit, python-unit, venv, single-workspace, multi-workspace, debugger, functional] steps: - name: Checkout uses: actions/checkout@v2 @@ -372,7 +372,7 @@ jobs: matrix: # We're not running CI on macOS for now because it's one less matrix entry to lower the number of runners used, # macOS runners are expensive, and we assume that Ubuntu is enough to cover the UNIX case. - os: [ubuntu-latest] + os: [ubuntu-latest, windows-latest] python: [3.8] steps: - name: Checkout @@ -462,8 +462,8 @@ jobs: curl -s -X DELETE https://api.github.com/repos/microsoft/vscode-python/git/refs/tags/${{env.LKG_TAG}} \ -H "Authorization: token ${{secrets.GITHUB_TOKEN}}" - # We need to make 2 calls when creating an annotated tag: first create the tag object, and then the tag reference. - # If we wanted to create a lightweight tag we would only need the tag reference. + # We need 2 calls when creating an annotated tag: first create the tag object, then the tag reference. + # If we only wanted a lightweight tag we would only need to create a tag reference. # See https://developer.github.com/v3/git/tags/#create-a-tag-object - name: Create a tag object # Curl syntax explanation: https://stackoverflow.com/a/36778045