Skip to content

Commit a6dc358

Browse files
authored
Remove start page and its build dependencies (#16834)
* First deletion pass * Remove commands & settings * Remove cusotm webview implementation * Remove build steps * Re-add mocks * Update Pylance prompt * Remove "jupyter not installed" notification * Add news file * Remove a plugin that seems to be unused * Remove gulpfile ref * Remove telemetry constant * Remove unused telemetry event * Remove tsx checks * Undo some formatting changes * Remove react-related deps * Re-add ESLint plugins * Remove comment * Remove out/server from gulpfile * Remove ABExperiments type
1 parent eafbd9e commit a6dc358

91 files changed

Lines changed: 661 additions & 8740 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.eslintignore

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -393,7 +393,6 @@ src/client/common/nuget/types.ts
393393
src/client/common/nuget/nugetService.ts
394394
src/client/common/cancellation.ts
395395
src/client/common/interpreterPathService.ts
396-
src/client/common/startPage/startPageMessageListener.ts
397396
src/client/common/application/applicationShell.ts
398397
src/client/common/application/languageService.ts
399398
src/client/common/application/notebook.ts
@@ -511,25 +510,3 @@ src/client/workspaceSymbols/generator.ts
511510
src/client/workspaceSymbols/parser.ts
512511
src/client/workspaceSymbols/provider.ts
513512

514-
src/client/common/startPage/codeCssGenerator.ts
515-
src/client/common/startPage/themeFinder.ts
516-
src/client/common/startPage/webviewHost.ts
517-
src/client/common/startPage/webviewPanelHost.ts
518-
src/startPage-ui/common/main.ts
519-
src/startPage-ui/react-common/image.tsx
520-
src/startPage-ui/react-common/locReactSide.ts
521-
src/startPage-ui/react-common/logger.ts
522-
src/startPage-ui/react-common/postOffice.ts
523-
src/startPage-ui/startPage/index.tsx
524-
src/test/startPage/mockCommandManager.ts
525-
src/test/startPage/mockDocument.ts
526-
src/test/startPage/mockDocumentManager.ts
527-
src/test/startPage/mockExtensions.ts
528-
src/test/startPage/mockTextEditor.ts
529-
src/test/startPage/mockWorkspaceConfig.ts
530-
src/test/startPage/mockWorkspaceFolder.ts
531-
src/test/startPage/mountedWebView.ts
532-
src/test/startPage/mountedWebViewFactory.ts
533-
src/test/startPage/reactHelpers.ts
534-
src/test/startPage/webBrowserPanel.ts
535-
src/test/startPage/webBrowserPanelProvider.ts

.eslintrc

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,6 @@
7777
"selector": "ForInStatement",
7878
"message": "for..in loops iterate over the entire prototype chain, which is virtually never what you want. Use Object.{keys,values,entries}, and iterate over the resulting array."
7979
},
80-
8180
{
8281
"selector": "LabeledStatement",
8382
"message": "Labels are a form of GOTO; using them makes code confusing and hard to maintain and understand."
@@ -97,12 +96,6 @@
9796
}
9897
],
9998
"operator-assignment": "off",
100-
"react/jsx-filename-extension": [
101-
1,
102-
{
103-
"extensions": [".tsx"]
104-
}
105-
],
10699
"strict": "off"
107100
}
108101
}

.sonarcloud.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
sonar.sources=src/client,src/startPage-ui
1+
sonar.sources=src/client
22
sonar.tests=src/test
33
sonar.cfamily.build-wrapper-output.bypass=true
44
sonar.cpd.exclusions=src/client/activation/**/*.ts

.vscode/tasks.json

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -12,23 +12,14 @@
1212
"type": "npm",
1313
"script": "compile",
1414
"isBackground": true,
15-
"problemMatcher": ["$tsc-watch"],
15+
"problemMatcher": [
16+
"$tsc-watch"
17+
],
1618
"group": {
1719
"kind": "build",
1820
"isDefault": true
1921
}
2022
},
21-
{
22-
"label": "Compile Web Views",
23-
"type": "npm",
24-
"script": "compile-webviews-watch",
25-
"isBackground": true,
26-
"group": {
27-
"kind": "build",
28-
"isDefault": true
29-
},
30-
"problemMatcher": ["$tsc-watch"]
31-
},
3223
{
3324
"label": "Run Unit Tests",
3425
"type": "npm",

.vscodeignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
**/*.map
22
**/*.analyzer.html
3-
!out/startPage-ui/viewers/
43
*.vsix
54
.editorconfig
65
.env

build/webpack/plugins/less-plugin-base64.js

Lines changed: 0 additions & 72 deletions
This file was deleted.

build/webpack/webpack.startPage-ui-viewers.config.js

Lines changed: 0 additions & 8 deletions
This file was deleted.

0 commit comments

Comments
 (0)