Apply suggestions from code review

luabud · brettcannon · web-flow · commit 9ff03e4597f5 · 2022-11-17T09:22:11.000-08:00
Co-authored-by: Brett Cannon &lt;brett@python.org&gt;
diff --git a/gulpfile.js b/gulpfile.js
@@ -85,6 +85,8 @@ async function addExtensionPackDependencies() {
     packageJson.extensionPack = ['ms-python.vscode-pylance', 'ms-python.isort'].concat(
         packageJson.extensionPack ? packageJson.extensionPack : [],
     );
+    // Remove potential duplicates.
+    packageJson.extensionPack = packageJson.extensionPack.filter((item, index) => packageJson.extensionPack.indexOf(item) === index);
     await fsExtra.writeFile('package.json', JSON.stringify(packageJson, null, 4), 'utf-8');
 }
 

Original file line number	Diff line number	Diff line change
`@@ -85,6 +85,8 @@ async function addExtensionPackDependencies() {`
`85`	`85`	`packageJson.extensionPack = ['ms-python.vscode-pylance', 'ms-python.isort'].concat(`
`86`	`86`	`packageJson.extensionPack ? packageJson.extensionPack : [],`
`87`	`87`	`);`
	`88`	`+ // Remove potential duplicates.`
	`89`	`+ packageJson.extensionPack = packageJson.extensionPack.filter((item, index) => packageJson.extensionPack.indexOf(item) === index);`
`88`	`90`	`await fsExtra.writeFile('package.json', JSON.stringify(packageJson, null, 4), 'utf-8');`
`89`	`91`	`}`
`90`	`92`