Why are conda tests getting skipped

Kartik Raj · Kartik Raj · commit 45ef0e124254 · 2021-06-24T18:22:32.000-07:00
diff --git a/.github/workflows/pr-check.yml b/.github/workflows/pr-check.yml
@@ -195,7 +195,6 @@ jobs:
       - name: Run venv tests
         env:
           TEST_FILES_SUFFIX: testvirtualenvs
-          VSC_PYTHON_CI_TEST_GREP: 'Activation of Environments in Terminal'
           CI_PYTHON_VERSION: ${{matrix.python}}
         uses: GabrielBB/xvfb-action@v1.5
         with:
diff --git a/src/test/common/terminals/environmentActivationProviders/terminalActivation.testvirtualenvs.ts b/src/test/common/terminals/environmentActivationProviders/terminalActivation.testvirtualenvs.ts
@@ -163,29 +163,29 @@ suite('Activation of Environments in Terminal', () => {
         expect(fileSystem.arePathsSame(content, envPath)).to.equal(true, 'Environment not activated');
     }
 
-    // test('Should not activate', async () => {
-    //     await updateSetting(
-    //         'terminal.activateEnvironment',
-    //         false,
-    //         vscode.workspace.workspaceFolders![0].uri,
-    //         vscode.ConfigurationTarget.WorkspaceFolder,
-    //     );
-    //     const content = await openTerminalAndAwaitCommandContent(waitTimeForActivation, file, outputFile, 5_000);
-    //     expect(fileSystem.arePathsSame(content, PYTHON_PATH)).to.equal(false, 'Environment not activated');
-    // });
+    test('Should not activate', async () => {
+        await updateSetting(
+            'terminal.activateEnvironment',
+            false,
+            vscode.workspace.workspaceFolders![0].uri,
+            vscode.ConfigurationTarget.WorkspaceFolder,
+        );
+        const content = await openTerminalAndAwaitCommandContent(waitTimeForActivation, file, outputFile, 5_000);
+        expect(fileSystem.arePathsSame(content, PYTHON_PATH)).to.equal(false, 'Environment not activated');
+    });
 
-    // test('Should activate with venv', async function () {
-    //     if (process.env.CI_PYTHON_VERSION && process.env.CI_PYTHON_VERSION.startsWith('2.')) {
-    //         this.skip();
-    //     }
-    //     await testActivation(envPaths.venvPath);
-    // });
-    // test('Should activate with pipenv', async () => {
-    //     await testActivation(envPaths.pipenvPath);
-    // });
-    // test('Should activate with virtualenv', async () => {
-    //     await testActivation(envPaths.virtualEnvPath);
-    // });
+    test('Should activate with venv', async function () {
+        if (process.env.CI_PYTHON_VERSION && process.env.CI_PYTHON_VERSION.startsWith('2.')) {
+            this.skip();
+        }
+        await testActivation(envPaths.venvPath);
+    });
+    test('Should activate with pipenv', async () => {
+        await testActivation(envPaths.pipenvPath);
+    });
+    test('Should activate with virtualenv', async () => {
+        await testActivation(envPaths.virtualEnvPath);
+    });
     test('Should activate with conda', async () => {
         await terminalSettings.update(
             'integrated.shell.windows',
