Skip to content

VSCode 1.54.1 breaks spawned processes with cwd option #118267

Closed
Closed
VSCode 1.54.1 breaks spawned processes with cwd option#118267
Assignees
deepak1556
Labels
bugIssue identified by VS Code Team member as probable bugconfirmedIssue has been confirmed by VS Code Team memberinsiders-releasedPatch has been released in VS Code Insidersmacos-big-surverifiedVerification succeeded
Milestone
May 2021

Description

@jeremie-stripe
Jérémie Laval (jeremie-stripe)
opened on Mar 5, 2021
  • VS Code Version: 1.54.1
  • OS Version: macOS 10.15.17

Steps to Reproduce:

  1. Upgrade to VSCode 1.54.1 from 1.53
  2. A few of our extensions are failing to start because spawned shell script processes do not work

Does this issue occur when all extensions are disabled?: No

We run a few extensions (including an LSP server) which essentially spawn an external process executing shell wrapper scripts and attempts to manipulate its standard IO.

Since upgrading to 1.54.1 we have noticed a strange behavior where when writing to the external process stdin we get EBADF error. This seems specifically to only occur when attempting to execute shell script directly as when we modify the spawn (or similar functions) to invoke the script via bash directly it works fine.

This is illustrated by the following test cases executed while debugging VSCode:

> cp.execFile("cat", ['-'], options, cb).stdin.write("foo\n")
true
> cp.execFile("scripts/bin/wrapper.sh", ["cat", "-"], options, cb).stdin.write("foo\n")
Uncaught Error: write EBADF
> cp.execFile("bash", ["scripts/bin/wrapper.sh", "cat", "-"], options, cb).stdin.write("foo\n")
true

Where wrapper.sh ultimately will exec the rest of the command line.

Activity

  1. github-actions
    added
    new release
    on Mar 5, 2021
  2. VS Code Issue Triage Bot (vscode-triage-bot)
    assigned
    Andre Weinand (weinand)
    on Mar 5, 2021
  3. Andre Weinand (weinand)
    removed their assignment
    on Mar 6, 2021
  4. Martin Aeschlimann (aeschli)
    assigned
    Robo (deepak1556)
    on Mar 8, 2021
  5. github-actions
    removed
    new release
    on Mar 9, 2021
  6. Robo (deepak1556)
    added
    bugIssue identified by VS Code Team member as probable bug
    confirmedIssue has been confirmed by VS Code Team member
    macos-big-sur
    on Mar 10, 2021
  7. Robo (deepak1556)
    modified the milestones: March 2021, February 2021 Recovery 2 on Mar 10, 2021
  8. Robo (deepak1556)
    added
    candidateIssue identified as probable candidate for fixing in the next release
    on Mar 10, 2021
  9. Robo (deepak1556)
    added a commit that references this issue on Mar 11, 2021

    chore: bump electron@11.3.0

    f734f29
  10. SteVen Batten (sbatten)
    added a commit that references this issue on Mar 11, 2021

    chore: bump electron@11.3.0 (#118680)

    fd6f3bc

  11. deepak1556 commented on Mar 11, 2021

    @deepak1556
    Robo (deepak1556)
    on Mar 11, 2021
    Collaborator

    We just released an update to VS Code Insiders that has a fix for this issue. Please try it out and let us know.

  12. 35 remaining items

  13. deepak1556 commented on May 12, 2021

    @deepak1556
    Robo (deepak1556)
    on May 12, 2021
    Collaborator

    This turned out to be a bug in the posix_spawnp implementation where a relative executable path will cause it to successfully launch the program, but erroneously return ENOENT when used with posix_spawn_file_actions_addchdir_np because of the stat call performed on the executable path after the child process is launched. Ref: https://opensource.apple.com/source/Libc/Libc-1439.40.11/sys/posix_spawn.c.auto.html

    Have resorted to use pthread_chdir_np instead to respect the cwd option, will update here once the updated runtime is available.

  14. Robo (deepak1556)
    closed this as completedin d17d7caon May 14, 2021
  15. VS Code Issue Triage Bot (vscode-triage-bot)
    added
    unreleasedPatch has not yet been released in VS Code Insiders
    insiders-releasedPatch has been released in VS Code Insiders
    and removed
    unreleasedPatch has not yet been released in VS Code Insiders
    on May 14, 2021

  16. jeremie-stripe commented on May 14, 2021

    @jeremie-stripe
    Jérémie Laval (jeremie-stripe)
    on May 14, 2021
    Author

    Robo (@deepak1556) thanks for figuring it out! I just tested with the latest insiders version (version info below) and I can confirm that our workloads are now properly working again!

    Version: 1.57.0-insider (Universal)
Commit: 5246162662ffa9f16a70dc2b94f13b0d15511e64
Date: 2021-05-14T08:49:16.464Z
Electron: 12.0.7
Chrome: 89.0.4389.128
Node.js: 14.16.0
V8: 8.9.255.25-electron.0
OS: Darwin x64 20.4.0
  17. Robo (deepak1556)
    added
    z-author-verified
    on May 15, 2021
  18. Matt Bierner (mjbvz)
    added
    verifiedVerification succeeded
    on Jun 4, 2021
  19. github-actions
    locked and limited conversation to collaborators on Jun 28, 2021
  20. Charles Gagnon (Charles-Gagnon)
    added 2 commits that reference this issue on Jul 1, 2021

    chore: bump electron@12.0.7

    5f0cd77

    chore: bump electron@12.0.7

    8f73547
  21. Benjamin Pasero (bpasero)
    added this to VSCode Electron Integrationon Jul 24, 2023
  22. Benjamin Pasero (bpasero)
    moved this to ✔️ Done / Deferred in VSCode Electron Integrationon Jul 24, 2023
  23. Anthony lopez (whoshotu)
    added 2 commits that reference this issue on May 6, 2026

    chore: bump electron@12.0.5

    9064c90

    chore: bump electron@12.0.7

    d17d7ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable bugconfirmedIssue has been confirmed by VS Code Team memberinsiders-releasedPatch has been released in VS Code Insidersmacos-big-surverifiedVerification succeeded

Type

No type

Projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions