Fixed bug with AppCredentials passed to adapter not being used. (#969)

tracyboehrer · web-flow · commit 12aa58d58caa · 2021-02-10T16:04:45.000-06:00
diff --git a/libraries/bot-builder/src/main/java/com/microsoft/bot/builder/BotFrameworkAdapter.java b/libraries/bot-builder/src/main/java/com/microsoft/bot/builder/BotFrameworkAdapter.java
@@ -1215,6 +1215,7 @@ private CompletableFuture<AppCredentials> getAppCredentials(String appId, String
         // moving forward
         if (appCredentials != null) {
             appCredentialMap.put(cacheKey, appCredentials);
+            return CompletableFuture.completedFuture(appCredentials);
         }
 
         return credentialProvider.getAppPassword(appId).thenApply(appPassword -> {

Original file line number	Diff line number	Diff line change
`@@ -1215,6 +1215,7 @@ private CompletableFuture<AppCredentials> getAppCredentials(String appId, String`
`1215`	`1215`	`// moving forward`
`1216`	`1216`	`if (appCredentials != null) {`
`1217`	`1217`	`appCredentialMap.put(cacheKey, appCredentials);`
	`1218`	`+ return CompletableFuture.completedFuture(appCredentials);`
`1218`	`1219`	`}`
`1219`	`1220`
`1220`	`1221`	`return credentialProvider.getAppPassword(appId).thenApply(appPassword -> {`