Repository navigation
Commit 7bfd07b
authored
CI: Drop the path filter that matches no directory (#10236)
`python-test-coverage.yml` lists `python/tests/unit/**` under both `pull_request.paths`
and `push.paths`, but that directory has never existed in this repository:
```console
$ ls python/tests
samples
$ git log --oneline --all -- python/tests/unit
(no output)
```
Every Python test lives under `python/packages/*/tests/`, which the same filter already
covers with `python/packages/**`. So the line cannot match anything, and it cannot be
responsible for triggering the workflow either.
The cost is not runtime, it is what a reader concludes: a paths list is documentation of
"what this check watches", and a reader deciding whether their change will be covered reads
`python/tests/unit/**` as "unit tests live there". They don't. If tests are ever moved to
that location, the entry should come back as part of that move, where it can be tested.
Removing two lines from one file; the workflow's behaviour is unchanged because the pattern
never matched.
Co-authored-by: lxcxjxhx <lxcxjxhx@users.noreply.github.com>1 parent 33a49bd commit 7bfd07b
1 file changed
Lines changed: 0 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
9 | 8 | | |
10 | 9 | | |
11 | 10 | | |
12 | 11 | | |
13 | 12 | | |
14 | 13 | | |
15 | 14 | | |
16 | | - | |
17 | 15 | | |
18 | 16 | | |
19 | 17 | | |
| |||
0 commit comments