Skip to content

Pull off full code points in template literal inference#63537

Draft
jakebailey wants to merge 1 commit into
microsoft:mainfrom
jakebailey:template-type-surrogate
Draft

Pull off full code points in template literal inference#63537
jakebailey wants to merge 1 commit into
microsoft:mainfrom
jakebailey:template-type-surrogate

Conversation

@jakebailey
Copy link
Copy Markdown
Member

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jun 5, 2026
@jakebailey
Copy link
Copy Markdown
Member Author

@typescript-bot user test this
@typescript-bot test top800
@typescript-bot run dt
@typescript-bot perf test this faster

@typescript-bot
Copy link
Copy Markdown
Collaborator

typescript-bot commented Jun 5, 2026

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
user test this ✅ Started ✅ Results
test top800 ✅ Started
run dt ✅ Started ✅ Results
perf test this faster ✅ Started 👀 Results

@typescript-bot
Copy link
Copy Markdown
Collaborator

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

@typescript-bot
Copy link
Copy Markdown
Collaborator

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/63537/merge:

There were infrastructure failures potentially unrelated to your change:

  • 1 instance of "Git clone failed"
  • 1 instance of "Package install failed"

Otherwise...

Everything looks good!

@typescript-bot
Copy link
Copy Markdown
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - node (v18.15.0, x64)
Errors 3 3 ~ ~ ~ p=1.000 n=6
Symbols 82,521 82,521 ~ ~ ~ p=1.000 n=6
Types 125,280 125,280 ~ ~ ~ p=1.000 n=6
Memory Used 275,022k (± 0.53%) 276,151k (± 0.70%) ~ 274,348k 277,997k p=0.810 n=6
Memory Allocs 0 0 ~ ~ ~ p=1.000 n=6
Config Time 0s 0s ~ ~ ~ p=1.000 n=6
Parse Time 1.30s (± 0.94%) 1.30s (± 0.63%) ~ 1.29s 1.31s p=0.120 n=6
Bind Time 0.75s 0.75s ~ ~ ~ p=1.000 n=6
Check Time 14.36s (± 3.15%) 14.13s (± 0.38%) ~ 14.05s 14.21s p=0.378 n=6
Emit Time 2.66s (± 0.56%) 2.65s (± 0.69%) ~ 2.63s 2.68s p=0.289 n=6
Total Time 19.09s (± 2.44%) 18.84s (± 0.30%) ~ 18.74s 18.91s p=0.378 n=6
angular-1 - node (v18.15.0, x64)
Errors 3 3 ~ ~ ~ p=1.000 n=6
Symbols 959,140 959,140 ~ ~ ~ p=1.000 n=6
Types 416,033 416,033 ~ ~ ~ p=1.000 n=6
Memory Used 1,261,138k (± 0.00%) 1,261,149k (± 0.00%) ~ 1,261,091k 1,261,200k p=0.689 n=6
Memory Allocs 0 0 ~ ~ ~ p=1.000 n=6
Config Time 0s 0s ~ ~ ~ p=1.000 n=6
Parse Time 6.53s (± 0.65%) 6.54s (± 0.65%) ~ 6.50s 6.62s p=0.808 n=6
Bind Time 1.97s (± 0.38%) 1.97s (± 0.38%) ~ 1.96s 1.98s p=1.000 n=6
Check Time 32.46s (± 0.30%) 32.45s (± 0.26%) ~ 32.32s 32.55s p=0.810 n=6
Emit Time 15.09s (± 0.36%) 15.10s (± 0.41%) ~ 15.02s 15.17s p=0.748 n=6
Total Time 56.06s (± 0.14%) 56.06s (± 0.24%) ~ 55.94s 56.31s p=0.810 n=6
mui-docs - node (v18.15.0, x64)
Errors 11,246 11,246 ~ ~ ~ p=1.000 n=6
Symbols 2,568,551 2,568,551 ~ ~ ~ p=1.000 n=6
Types 794,921 794,921 ~ ~ ~ p=1.000 n=6
Memory Used 2,878,309k (± 0.00%) 2,878,263k (± 0.00%) ~ 2,878,158k 2,878,354k p=0.298 n=6
Memory Allocs 0 0 ~ ~ ~ p=1.000 n=6
Config Time 0s 0s ~ ~ ~ p=1.000 n=6
Parse Time 7.92s (± 0.39%) 7.91s (± 0.19%) ~ 7.88s 7.92s p=0.565 n=6
Bind Time 2.07s (± 0.85%) 2.07s (± 0.58%) ~ 2.05s 2.08s p=0.858 n=6
Check Time 81.68s (± 0.32%) 81.52s (± 0.66%) ~ 80.74s 82.26s p=0.575 n=6
Emit Time 0.30s (± 1.37%) 0.30s (± 1.74%) ~ 0.29s 0.30s p=0.595 n=6
Total Time 91.97s (± 0.29%) 91.80s (± 0.59%) ~ 91.01s 92.55s p=0.630 n=6
self-build-src - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,227,405 1,227,406 +1 (+ 0.00%) ~ ~ p=0.001 n=6
Types 267,208 267,208 ~ ~ ~ p=1.000 n=6
Memory Used 2,474,192k (± 7.59%) 2,534,700k (± 7.85%) ~ 2,351,908k 2,716,911k p=1.000 n=6
Memory Allocs 0 0 ~ ~ ~ p=1.000 n=6
Config Time 0s 0s ~ ~ ~ p=1.000 n=6
Parse Time 5.20s (± 0.83%) 5.23s (± 0.88%) ~ 5.17s 5.28s p=0.423 n=6
Bind Time 1.87s (± 1.39%) 1.86s (± 1.25%) ~ 1.83s 1.89s p=0.421 n=6
Check Time 35.77s (± 1.19%) 35.58s (± 0.78%) ~ 35.30s 35.95s p=0.471 n=6
Emit Time 3.10s (± 4.34%) 3.02s (± 3.54%) ~ 2.91s 3.22s p=0.066 n=6
Total Time 45.94s (± 0.79%) 45.69s (± 0.51%) ~ 45.45s 45.91s p=0.173 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,227,405 1,227,406 +1 (+ 0.00%) ~ ~ p=0.001 n=6
Types 267,208 267,208 ~ ~ ~ p=1.000 n=6
Memory Used 2,785,452k (± 0.03%) 2,724,534k (± 5.40%) ~ 2,423,730k 2,786,859k p=0.128 n=6
Memory Allocs 0 0 ~ ~ ~ p=1.000 n=6
Config Time 0s 0s ~ ~ ~ p=1.000 n=6
Parse Time 6.76s (± 0.75%) 6.72s (± 1.07%) ~ 6.65s 6.83s p=0.173 n=6
Bind Time 2.27s (± 1.07%) 2.26s (± 0.98%) ~ 2.23s 2.29s p=0.747 n=6
Check Time 42.72s (± 0.75%) 43.00s (± 1.04%) ~ 42.40s 43.42s p=0.298 n=6
Emit Time 3.48s (± 2.96%) 3.64s (± 2.79%) 🔻+0.16s (+ 4.64%) 3.48s 3.71s p=0.030 n=6
Total Time 55.23s (± 0.82%) 55.63s (± 1.05%) ~ 54.81s 56.19s p=0.298 n=6
self-compiler - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 261,660 261,661 +1 (+ 0.00%) ~ ~ p=0.001 n=6
Types 104,323 104,323 ~ ~ ~ p=1.000 n=6
Memory Used 439,344k (± 0.01%) 439,364k (± 0.01%) ~ 439,310k 439,421k p=0.298 n=6
Memory Allocs 0 0 ~ ~ ~ p=1.000 n=6
Config Time 0s 0s ~ ~ ~ p=1.000 n=6
Parse Time 4.37s (± 0.55%) 4.40s (± 0.85%) ~ 4.33s 4.44s p=0.053 n=6
Bind Time 1.70s (± 0.74%) 1.70s (± 1.36%) ~ 1.66s 1.72s p=0.620 n=6
Check Time 23.96s (± 0.29%) 23.95s (± 0.21%) ~ 23.89s 24.02s p=1.000 n=6
Emit Time 1.93s (± 0.78%) 1.92s (± 0.97%) ~ 1.89s 1.94s p=0.289 n=6
Total Time 31.96s (± 0.20%) 31.98s (± 0.23%) ~ 31.87s 32.06s p=0.630 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors 271 271 ~ ~ ~ p=1.000 n=6
Symbols 225,897 225,897 ~ ~ ~ p=1.000 n=6
Types 93,564 93,564 ~ ~ ~ p=1.000 n=6
Memory Used 371,588k (± 0.01%) 371,597k (± 0.01%) ~ 371,530k 371,665k p=0.873 n=6
Memory Allocs 0 0 ~ ~ ~ p=1.000 n=6
Config Time 0s 0s ~ ~ ~ p=1.000 n=6
Parse Time 2.86s (± 0.49%) 2.86s (± 0.93%) ~ 2.82s 2.88s p=1.000 n=6
Bind Time 1.63s (± 0.60%) 1.61s (± 1.16%) ~ 1.58s 1.63s p=0.070 n=6
Check Time 17.43s (± 0.52%) 17.43s (± 0.36%) ~ 17.38s 17.55s p=1.000 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 21.92s (± 0.44%) 21.90s (± 0.21%) ~ 21.83s 21.97s p=0.688 n=6
vscode - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=NaN n=0
Symbols 0 0 ~ ~ ~ p=NaN n=0
Types 0 0 ~ ~ ~ p=NaN n=0
Memory Used 0k 0k ~ ~ ~ p=NaN n=0
Memory Allocs 0 0 ~ ~ ~ p=NaN n=0
Config Time 0s 0s ~ ~ ~ p=NaN n=0
Parse Time 0s 0s ~ ~ ~ p=NaN n=0
Bind Time 0s 0s ~ ~ ~ p=NaN n=0
Check Time 0s 0s ~ ~ ~ p=NaN n=0
Emit Time 0s 0s ~ ~ ~ p=NaN n=0
Total Time 0s 0s ~ ~ ~ p=NaN n=0
webpack - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 411,923 411,923 ~ ~ ~ p=1.000 n=6
Types 187,000 187,000 ~ ~ ~ p=1.000 n=6
Memory Used 582,081k (± 0.05%) 582,187k (± 0.04%) ~ 581,852k 582,400k p=0.378 n=6
Memory Allocs 0 0 ~ ~ ~ p=1.000 n=6
Config Time 0s 0s ~ ~ ~ p=1.000 n=6
Parse Time 6.05s (± 0.85%) 6.05s (± 0.19%) ~ 6.03s 6.06s p=0.376 n=6
Bind Time 2.62s (± 2.08%) 2.63s (± 1.65%) ~ 2.58s 2.67s p=0.747 n=6
Check Time 30.75s (± 0.33%) 30.61s (± 0.28%) ~ 30.52s 30.72s p=0.077 n=6
Emit Time 0.01s (±63.18%) 0.01s (±109.43%) ~ 0.00s 0.01s p=0.201 n=6
Total Time 39.44s (± 0.32%) 39.30s (± 0.27%) ~ 39.18s 39.44s p=0.054 n=6
xstate-main - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 821,648 821,648 ~ ~ ~ p=1.000 n=6
Types 247,134 247,134 ~ ~ ~ p=1.000 n=6
Memory Used 725,950k (± 0.04%) 726,012k (± 0.02%) ~ 725,773k 726,217k p=0.810 n=6
Memory Allocs 0 0 ~ ~ ~ p=1.000 n=6
Config Time 0s 0s ~ ~ ~ p=1.000 n=6
Parse Time 4.92s (± 1.01%) 4.93s (± 0.72%) ~ 4.88s 4.97s p=0.574 n=6
Bind Time 1.61s (± 1.00%) 1.61s (± 0.78%) ~ 1.59s 1.63s p=0.446 n=6
Check Time 24.01s (± 2.02%) 23.79s (± 0.37%) ~ 23.65s 23.92s p=1.000 n=6
Emit Time 0.00s (±244.70%) 0.01s (±167.16%) ~ 0.00s 0.02s p=0.527 n=6
Total Time 30.54s (± 1.53%) 30.34s (± 0.34%) ~ 30.18s 30.47s p=0.873 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants