Fix compile on save issues#10615
Merged
zhengbli merged 7 commits intoAug 31, 2016
Merged
Conversation
added 2 commits
August 30, 2016 14:41
| } | ||
| return Object.keys(fileNameSet); | ||
| const result: string[] = []; | ||
| for (const fileName in fileNameSet) { |
Contributor
There was a problem hiding this comment.
make a function shouldEmitFile:
function shouldEmitFile(scriptInfo: ScriptInfo) {
return !scriptInfo.hasMixedContent;
}then you can use it here and in calls to filter above?
|
|
||
| if (!fileInfo.isExternalModuleOrHasOnlyAmbientExternalModules()) { | ||
| return this.project.getFileNamesWithoutDefaultLib(); | ||
| return map(filter(this.project.getScriptInfosWithoutDefaultLib(), shouldEmitFile), info => info.fileName); |
Contributor
There was a problem hiding this comment.
this chunk of code look awfully similar to the one above. Can you pull this into method in base class? Also can you replace pair map + filter with loop to avoid creating intermediate array?
Contributor
There was a problem hiding this comment.
Actuall ygetScriptInfosWithoutDefaultLib is also implemented using filter but I don't think it is used anywhere else except for these two places. Can you have method Project.getAllEmittableFiles() that will internally fuse filter(is not default lib) + filter (should emit) + map (get file name) into one loop.
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issues: