Skip to content

TSServer : make the ScriptInfo standalone #2297

@basarat

Description

@basarat

In bringing in the efficient line handling / change set handling code from TSServer I've found that the heart of the code is really just the ScriptInfo.

I've needed to bring in all this code : https://github.com/TypeStrong/atom-typescript/blob/bdaff3204ee62de8ab83df962ae224081fbd245b/lib/main/lang/languageServiceHost.ts#L3-L1066

When all I really needed was this : https://github.com/TypeStrong/atom-typescript/blob/bdaff3204ee62de8ab83df962ae224081fbd245b/lib/main/lang/languageServiceHost.ts#L1017-L1066

I don't see host , defaultProject or fileWatcher used https://github.com/Microsoft/TypeScript/blob/37c6f69f015c3da3c709e2bae0786aa55a10a045/src/server/editorServices.ts#L23-L27 would be great if these dependicies were removed and ScriptInfo was made public (exported).

refs TypeStrong/atom-typescript#179

Please correct me if my understanding of this code is correct ❤️

/cc @steveluc @mhegazy

Metadata

Metadata

Assignees

No one assigned

    Labels

    QuestionAn issue which isn't directly actionable in code

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions