Update src/services/codefixes/helpers.ts

blickly · sandersn · web-flow · commit ee3d89e13d6f · 2024-08-29T14:55:22.000-07:00
Simplify loop

Co-authored-by: Nathan Shively-Sanders &lt;293473+sandersn@users.noreply.github.com&gt;
diff --git a/src/services/codefixes/helpers.ts b/src/services/codefixes/helpers.ts
@@ -625,11 +625,9 @@ function endOfRequiredTypeParameters(checker: TypeChecker, type: GenericType): n
     next_cutoff: for (let cutoff = 0; cutoff < fullTypeArguments.length; cutoff++) {
         const typeArguments = fullTypeArguments.slice(0, cutoff);
         const filledIn = checker.fillMissingTypeArguments(typeArguments, target.typeParameters, cutoff, /*isJavaScriptImplicitAny*/ false);
-        for (let i = 0; i < filledIn.length; i++) {
-            // If they don't match, then we haven't yet reached the right cutoff
-            if (filledIn[i] !== fullTypeArguments[i]) continue next_cutoff;
+        if (filledIn.every((fill, i) => fill === fullTypeArguments[i])) {
+            return cutoff;
         }
-        return cutoff;
     }
     // If we make it all the way here, all the type arguments are required.
     return fullTypeArguments.length;

Original file line number	Diff line number	Diff line change
`@@ -625,11 +625,9 @@ function endOfRequiredTypeParameters(checker: TypeChecker, type: GenericType): n`
`625`	`625`	`next_cutoff: for (let cutoff = 0; cutoff < fullTypeArguments.length; cutoff++) {`
`626`	`626`	`const typeArguments = fullTypeArguments.slice(0, cutoff);`
`627`	`627`	`const filledIn = checker.fillMissingTypeArguments(typeArguments, target.typeParameters, cutoff, /isJavaScriptImplicitAny/ false);`
`628`		`- for (let i = 0; i < filledIn.length; i++) {`
`629`		`- // If they don't match, then we haven't yet reached the right cutoff`
`630`		`- if (filledIn[i] !== fullTypeArguments[i]) continue next_cutoff;`
	`628`	`+ if (filledIn.every((fill, i) => fill === fullTypeArguments[i])) {`
	`629`	`+ return cutoff;`
`631`	`630`	`}`
`632`		`- return cutoff;`
`633`	`631`	`}`
`634`	`632`	`// If we make it all the way here, all the type arguments are required.`
`635`	`633`	`return fullTypeArguments.length;`