Skip to content

Commit 01c23d6

Browse files
DanielRosenwasserDanielRosenwasser
authored
Switch the default of --strict to true (#63087)
1 parent 43db4c1 commit 01c23d6

13,088 files changed

Lines changed: 127635 additions & 53265 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎src/compiler/commandLineParser.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -899,7 +899,7 @@ const commandOptionsWithoutBuild: CommandLineOption[] = [
899899
showInSimplifiedHelpView: true,
900900
category: Diagnostics.Type_Checking,
901901
description: Diagnostics.Enable_all_strict_type_checking_options,
902-
defaultValueDescription: false,
902+
defaultValueDescription: true,
903903
},
904904
{
905905
name: "noImplicitAny",

‎src/compiler/utilities.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9310,7 +9310,7 @@ export type StrictOptionName =
93109310

93119311
/** @internal */
93129312
export function getStrictOptionValue(compilerOptions: CompilerOptions, flag: StrictOptionName): boolean {
9313-
return compilerOptions[flag] === undefined ? !!compilerOptions.strict : !!compilerOptions[flag];
9313+
return compilerOptions[flag] === undefined ? (compilerOptions.strict !== false) : !!compilerOptions[flag];
93149314
}
93159315

93169316
/** @internal */

‎tests/baselines/reference/2dArrays.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ class Board {
1818
}
1919

2020
//// [2dArrays.js]
21+
"use strict";
2122
class Cell {
2223
}
2324
class Ship {

‎tests/baselines/reference/2dArrays.types‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,14 @@ class Board {
2424
ships: Ship[] = [];
2525
>ships : Ship[]
2626
> : ^^^^^^
27-
>[] : undefined[]
28-
> : ^^^^^^^^^^^
27+
>[] : never[]
28+
> : ^^^^^^^
2929

3030
cells: Cell[] = [];
3131
>cells : Cell[]
3232
> : ^^^^^^
33-
>[] : undefined[]
34-
> : ^^^^^^^^^^^
33+
>[] : never[]
34+
> : ^^^^^^^
3535

3636
private allShipsSunk() {
3737
>allShipsSunk : () => boolean

‎tests/baselines/reference/AmbientModuleAndAmbientFunctionWithTheSameNameAndCommonRoot.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ var cl = Point();
1414
var cl = Point.Origin;
1515

1616
//// [test.js]
17+
"use strict";
1718
var cl;
1819
var cl = Point();
1920
var cl = Point.Origin;

‎tests/baselines/reference/AmbientModuleAndAmbientWithSameNameAndCommonRoot.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ var p = new A.Point(0, 0); // unexpected error here, bug 840000
2626

2727

2828
//// [test.js]
29+
"use strict";
2930
var p;
3031
var p = A.Point.Origin;
3132
var p = new A.Point(0, 0); // unexpected error here, bug 840000

‎tests/baselines/reference/AmbientModuleAndNonAmbientClassWithSameNameAndCommonRoot.js‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ var p = A.Point.Origin;
2323
var p = new A.Point(0, 0); // unexpected error here, bug 840000
2424

2525
//// [classPoint.js]
26+
"use strict";
2627
var A;
2728
(function (A) {
2829
class Point {
@@ -34,6 +35,7 @@ var A;
3435
A.Point = Point;
3536
})(A || (A = {}));
3637
//// [test.js]
38+
"use strict";
3739
var p;
3840
var p = A.Point.Origin;
3941
var p = new A.Point(0, 0); // unexpected error here, bug 840000

‎tests/baselines/reference/AmbientModuleAndNonAmbientFunctionWithTheSameNameAndCommonRoot.js‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,12 @@ var cl = Point();
1616
var cl = Point.Origin;
1717

1818
//// [function.js]
19+
"use strict";
1920
function Point() {
2021
return { x: 0, y: 0 };
2122
}
2223
//// [test.js]
24+
"use strict";
2325
var cl;
2426
var cl = Point();
2527
var cl = Point.Origin;

‎tests/baselines/reference/ArrowFunction1.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,6 @@ var v = (a: ) => {
66
};
77

88
//// [ArrowFunction1.js]
9+
"use strict";
910
var v = (a) => {
1011
};

‎tests/baselines/reference/ArrowFunction3.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ var v = (a): => {
66
};
77

88
//// [ArrowFunction3.js]
9+
"use strict";
910
var v = (a);
1011
{
1112
}

0 commit comments

Comments
 (0)