lib/tinyusb: Update to version 0.20.0-1086.#19359
Draft
andrewleech wants to merge 1 commit into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19359 +/- ##
=======================================
Coverage 98.51% 98.51%
=======================================
Files 176 176
Lines 22904 22904
=======================================
Hits 22563 22563
Misses 341 341 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Code size report: |
36e1c15 to
f53c6f2
Compare
The bundled TinyUSB device endpoint-transfer API gained a trailing `bool is_isr` argument on usbd_edpt_xfer()/usbd_edpt_xfer_fifo() and on the matching dcd_edpt_xfer()/dcd_edpt_xfer_fifo() driver entry points, and the stm32_fsdev driver was split into a shared fsdev_common.c. Adapt the in-tree users so the bump builds across ports: - extmod/machine_usb_device.c: pass is_isr=false on the USBDevice.submit_xfer() path (never an ISR), guarded by TUSB_VERSION_NUMBER so ports building against an older bundled TinyUSB (e.g. esp32 via ESP-IDF) still compile. - ports/alif/tinyusb_port: the port's custom dcd driver takes the new argument on both entry points (unused by this driver). - ports/stm32: build the new lib/tinyusb fsdev_common.c, which provides the PMA/btable helpers used by dcd_stm32_fsdev.c. Signed-off-by: Andrew Leech <andrew@alelec.net>
f53c6f2 to
8b82fb6
Compare
Member
|
Thanks for doing this. It would be great if we could wait for a release though, and I thought that would be very soon: hathach/tinyusb#3229 (reply in thread) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the bundled TinyUSB from
0.19.0-24(aa0fc2e08) to0.20.0-1086(0afee06e9, current upstream master). The submodule pin has not moved since #18406 (Nov 2025); TinyUSB master has since changed the device endpoint-transfer API, so this also adapts the in-tree glue.API change adapted
TinyUSB added a trailing
bool is_isrargument to the device transfer entry points:usbd_edpt_xfer()/usbd_edpt_xfer_fifo()(device stack API)dcd_edpt_xfer()/dcd_edpt_xfer_fifo()(driver entry points)In-tree changes:
extmod/machine_usb_device.c: the single caller is theUSBDevice.submit_xfer()path, which runs from the MicroPython scheduler and never an ISR, so it passesis_isr = false.ports/alif/tinyusb_port/tusb_alif_dcd.c: this port ships a custom dcd driver; its two transfer entry points (and the internaldcd_set_addresscall) take the new argument. It is unused by the driver, matching how the in-tree reference drivers handle it.Testing
RPI_PICO) builds clean locally.is_isrhandling is appropriate for that controller.Out of scope
The
tuh_init()->tusb_init(rhport, rh_init)host-init deprecation is not touched here: there is no USB host code on master (it is only relevant to out-of-treemachine.USBHostwork).Opening as a draft to run the full CI matrix and surface any remaining per-port breakage before review.