tests: Fix tests runs with MICROPY_ERROR_REPORTING_NONE.#19326
Draft
agatti wants to merge 9 commits into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19326 +/- ##
=======================================
Coverage 98.47% 98.47%
=======================================
Files 176 176
Lines 22845 22845
=======================================
Hits 22497 22497
Misses 348 348 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Code size report: |
dabd976 to
0b3eac6
Compare
This commit fixes two build errors occurring when building any modern port with error detail reporting is not enabled (ie. `MICROPY_ERROR_REPORTING` is set to `MICROPY_ERROR_REPORTING_NONE` when building). Signed-off-by: Alessandro Gatti <a.gatti@frob.it>
This commit updates the target info reporting script to work correctly even when error reporting is disabled, effectively skipping any error message attached to exceptions. The code expected the exception message to be an empty string, but it is `None` instead, making the script fail and the test runner not able to execute tests. Signed-off-by: Alessandro Gatti <a.gatti@frob.it>
Signed-off-by: Alessandro Gatti <a.gatti@frob.it>
Signed-off-by: Alessandro Gatti <a.gatti@frob.it>
Signed-off-by: Alessandro Gatti <a.gatti@frob.it>
Signed-off-by: Alessandro Gatti <a.gatti@frob.it>
0b3eac6 to
f13b7d0
Compare
Signed-off-by: Alessandro Gatti <a.gatti@frob.it>
Signed-off-by: Alessandro Gatti <a.gatti@frob.it>
Signed-off-by: Alessandro Gatti <a.gatti@frob.it>
f13b7d0 to
6276a29
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains fixes for MicroPython core and tests to make the Unix port pass tests when built with no error detail being generated in case of exceptions (ie.
MICROPY_ERROR_REPORTING_NONE).Some of the commits are here just to make sure things build and are executed from CI, marked with
DO NOT MERGE- they will be removed once the CI job stops failing.This PR depends on #19324 being merged first, otherwise things won't build when the support commits are removed.
Testing
There's a temporary CI job used to keep track of which tests still fail, and will be taken out once things work. Unless there's the need for an extra job running the test suite with this configuration, that is.
Generative AI
I did not use generative AI tools when creating this PR.