rp2: Update to use include linker scripts#19251
Draft
will-v-pi wants to merge 2 commits into
Draft
Conversation
6ff360f to
6ee1a07
Compare
Signed-off-by: William Vinnicombe <william.vinnicombe@raspberrypi.com>
Upstream pico-sdk now allows overriding parts of the linker script, rather than replacing the entire script. This change makes use of that functionality. Signed-off-by: William Vinnicombe <william.vinnicombe@raspberrypi.com>
6ee1a07 to
c9d8f23
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19251 +/- ##
=======================================
Coverage 98.47% 98.47%
=======================================
Files 176 176
Lines 22845 22845
=======================================
Hits 22497 22497
Misses 348 348 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Code size report: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the next pico-sdk release, the linker scripts will be re-formatted to allow only overriding certain parts of them, rather than having to replace the whole script. This draft PR shows how this functionality could be used for MicroPython, to make it simpler for MicroPython to keep the scripts up-to-date going forwards.
Note that this PR should not be merged as-is, as it updates the Pico SDK submodule to the current
developbranch where these linker script changes are. I'm raising it as a draft so that these changes can be included in any wider updates for the next Pico SDK release, either using this PR with a changedUpdate pico-sdk ...commit, or cherry-picked into a PR with wider updates.Testing
Checked the RPI_PICO and RPI_PICO2
firmware.elf.mapfiles for changes, and all changes seem reasonable (mostly related to the new SDK, including fixing a bug wherememcpyetc were in Flash on RP2350 due to a missing space). Also checked those ports both booted successfully.Generative AI
I did not use generative AI tools when creating this PR.