tools/autobuild: Print consistent msgs for start/pass/fail board build.#19249
Open
dpgeorge wants to merge 3 commits into
Open
tools/autobuild: Print consistent msgs for start/pass/fail board build.#19249dpgeorge wants to merge 3 commits into
dpgeorge wants to merge 3 commits into
Conversation
This "id" entry was removed from all `board.json` files in commit 1a99f74. Replace its use with the default value which is the board name. Signed-off-by: Damien George <damien@micropython.org>
Consistent messages are now printed to stdout (along with the main output
of the build process) when the build starts, and when it succeeds or fails.
For example:
bash: Autobuild started for RPI_PICO
...
...
bash: Autobuild succeeded for RPI_PICO
Or in the case of a failure:
bash: Autobuild started for RPI_PICO
...
...
bash: Autobuild failed for RPI_PICO
That helps searching the output logs for the results of all builds. And if
something failed, it's easy to locate the rest of the build logs for the
failure (they will be above the "Autobuild failed" message).
Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19249 +/- ##
=======================================
Coverage 98.47% 98.47%
=======================================
Files 176 176
Lines 22845 22845
=======================================
Hits 22497 22497
Misses 348 348 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Code size report: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consistent messages are now printed to stdout (along with the main output of the build process) when the build starts, and when it succeeds or fails.
For example:
Or in the case of a failure:
That helps searching the output logs for the results of all builds. And if something failed, it's easy to locate the rest of the build logs for the failure (they will be above the "Autobuild failed" message).
Testing
Tested locally running the example at the top of the script, namely:
That prints the messages correctly. Also manually added a build error to check that the fail message was printed correctly.
Trade-offs and Alternatives
Could instead generate a json file with the build results. But not sure that's worth the effort, and it would then be hard to find the rest of the build logs corresponding to the failed build (especially when there are >200 boards being built).
Generative AI
None used.