cc3200: Set pin direction first, then value. Fixes adafruit#1542.

danicampora · danicampora · commit 19502957357a · 2015-10-26T23:26:43.000+01:00
diff --git a/cc3200/mods/pybpin.c b/cc3200/mods/pybpin.c
@@ -290,16 +290,14 @@ STATIC void pin_obj_configure (const pin_obj_t *self) {
             default:
                 break;
             }
-
+            // configure the direction
+            MAP_GPIODirModeSet(self->port, self->bit, direction);
             // set the pin value
             if (self->value) {
                 MAP_GPIOPinWrite(self->port, self->bit, self->bit);
             } else {
                 MAP_GPIOPinWrite(self->port, self->bit, 0);
             }
-
-            // configure the direction
-            MAP_GPIODirModeSet(self->port, self->bit, direction);
         }
         // now set the alternate function
         MAP_PinModeSet (self->pin_num, self->af);
diff --git a/tests/wipy/pin.py b/tests/wipy/pin.py
@@ -1,5 +1,7 @@
-""" This test need a set of pins which can be set as inputs and have no external 
-    pull up or pull down connected.
+""" 
+This test need a set of pins which can be set as inputs and have no external 
+pull up or pull down connected.
+GP12 and GP17 must be connected together 
 """
 from machine import Pin
 import os
@@ -14,6 +16,13 @@
 else:
     raise Exception('Board not supported!')
 
+# test initial value
+p = Pin('GP12', Pin.IN)
+Pin('GP17', Pin.OUT, value=1)
+print(p() == 1)
+Pin('GP17', Pin.OUT, value=0)
+print(p() == 0)
+
 def test_noinit():
     for p in pin_map:
         pin = Pin(p)
diff --git a/tests/wipy/pin.py.exp b/tests/wipy/pin.py.exp
@@ -1,3 +1,5 @@
+True
+True
 1
 1
 1

Original file line number	Diff line number	Diff line change
`@@ -290,16 +290,14 @@ STATIC void pin_obj_configure (const pin_obj_t *self) {`
`290`	`290`	`default:`
`291`	`291`	`break;`
`292`	`292`	`}`
`293`		`-`
	`293`	`+ // configure the direction`
	`294`	`+ MAP_GPIODirModeSet(self->port, self->bit, direction);`
`294`	`295`	`// set the pin value`
`295`	`296`	`if (self->value) {`
`296`	`297`	`MAP_GPIOPinWrite(self->port, self->bit, self->bit);`
`297`	`298`	`} else {`
`298`	`299`	`MAP_GPIOPinWrite(self->port, self->bit, 0);`
`299`	`300`	`}`
`300`		`-`
`301`		`- // configure the direction`
`302`		`- MAP_GPIODirModeSet(self->port, self->bit, direction);`
`303`	`301`	`}`
`304`	`302`	`// now set the alternate function`
`305`	`303`	`MAP_PinModeSet (self->pin_num, self->af);`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+True`
	`2`	`+True`
`1`	`3`	`1`
`2`	`4`	`1`
`3`	`5`	`1`