Skip to content

Commit 075ca64

Browse files
author
danicampora
committed
cc3200: Fix UART tests after correcting uart.read() behaviour.
1 parent be2879c commit 075ca64

File tree

2 files changed

+11
-12
lines changed

2 files changed

+11
-12
lines changed

cc3200/mods/pybuart.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -65,18 +65,18 @@
6565
*******-***********************************************************************/
6666
#define PYBUART_FRAME_TIME_US(baud) ((11 * 1000000) / baud)
6767
#define PYBUART_2_FRAMES_TIME_US(baud) (PYBUART_FRAME_TIME_US(baud) * 2)
68-
#define PYBUART_RX_TIMEOUT_US(baud) (PYBUART_2_FRAMES_TIME_US(baud))
68+
#define PYBUART_RX_TIMEOUT_US(baud) (PYBUART_2_FRAMES_TIME_US(baud) * 8) // we need at least characters in the FIFO
6969

7070
#define PYBUART_TX_WAIT_US(baud) ((PYBUART_FRAME_TIME_US(baud)) + 1)
7171
#define PYBUART_TX_MAX_TIMEOUT_MS (5)
7272

7373
#define PYBUART_RX_BUFFER_LEN (256)
7474

7575
// interrupt triggers
76-
#define UART_TRIGGER_RX_ANY (0x01)
77-
#define UART_TRIGGER_RX_HALF (0x02)
78-
#define UART_TRIGGER_RX_FULL (0x04)
79-
#define UART_TRIGGER_TX_DONE (0x08)
76+
#define UART_TRIGGER_RX_ANY (0x01)
77+
#define UART_TRIGGER_RX_HALF (0x02)
78+
#define UART_TRIGGER_RX_FULL (0x04)
79+
#define UART_TRIGGER_TX_DONE (0x08)
8080

8181
/******************************************************************************
8282
DECLARE PRIVATE FUNCTIONS

tests/wipy/uart.py

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454
print(uart1.write(b'123') == 3)
5555
print(uart0.read(1) == b'1')
5656
print(uart0.read(2) == b'23')
57-
print(uart0.read() == b'')
57+
print(uart0.read() == None)
5858

5959
uart0.write(b'123')
6060
buf = bytearray(3)
@@ -79,28 +79,28 @@
7979
print(uart0.write(b'123456') == 6)
8080
print(uart1.read() == b'123456')
8181
print(uart1.write(b'123') == 3)
82-
print(uart0.read() == b'')
82+
print(uart0.read() == None)
8383

8484
# rx only mode
8585
uart0 = UART(0, 1000000, pins=(None, 'GP13'))
8686
print(uart0.write(b'123456') == 6)
87-
print(uart1.read() == b'')
87+
print(uart1.read() == None)
8888
print(uart1.write(b'123') == 3)
8989
print(uart0.read() == b'123')
9090

9191
# leave pins as they were (rx only mode)
9292
uart0 = UART(0, 1000000, pins=None)
9393
print(uart0.write(b'123456') == 6)
94-
print(uart1.read() == b'')
94+
print(uart1.read() == None)
9595
print(uart1.write(b'123') == 3)
9696
print(uart0.read() == b'123')
9797

9898
# no pin assignemnt
9999
uart0 = UART(0, 1000000, pins=(None, None))
100100
print(uart0.write(b'123456789') == 9)
101-
print(uart1.read() == b'')
101+
print(uart1.read() == None)
102102
print(uart1.write(b'123456789') == 9)
103-
print(uart0.read() == b'')
103+
print(uart0.read() == None)
104104
print(Pin.board.GP12)
105105
print(Pin.board.GP13)
106106

@@ -156,4 +156,3 @@
156156
uart.init(115200)
157157
print(uart)
158158
uart.read()
159-

0 commit comments

Comments
 (0)