Fixed tests for abstract factory.

spookylukey · spookylukey · commit 6127f9dbfdee · 2018-01-31T20:26:06.000+03:00
This all removes all the low value tests which were testing things
that were trivial, irrelevant to the point or now no longer exist.
diff --git a/creational/abstract_factory.py b/creational/abstract_factory.py
@@ -93,15 +93,16 @@ def random_animal():
         shop.show_pet()
         print("=" * 20)
 
-
 ### OUTPUT ###
 # We have a lovely Cat
 # It says meow
-#
-# ====================
+# 
 # We have a lovely Dog
 # It says woof
 # ====================
 # We have a lovely Cat
 # It says meow
 # ====================
+# We have a lovely Cat
+# It says meow
+# ====================
diff --git a/tests/test_abstract_factory.py b/tests/test_abstract_factory.py
@@ -1,8 +1,7 @@
 #!/usr/bin/env python
 # -*- coding: utf-8 -*-
 import unittest
-from creational.abstract_factory import PetShop,\
-    Dog, Cat, DogFactory, CatFactory, Pet
+from creational.abstract_factory import PetShop, Dog
 try:
     from unittest.mock import patch
 except ImportError:
@@ -12,54 +11,7 @@
 class TestPetShop(unittest.TestCase):
 
     def test_dog_pet_shop_shall_show_dog_instance(self):
-        f = DogFactory()
-        with patch.object(f, 'get_pet') as mock_f_get_pet,\
-                patch.object(f, 'get_food') as mock_f_get_food:
-            ps = PetShop(f)
-            ps.show_pet()
-            self.assertEqual(mock_f_get_pet.call_count, 1)
-            self.assertEqual(mock_f_get_food.call_count, 1)
-
-    def test_cat_pet_shop_shall_show_cat_instance(self):
-        f = CatFactory()
-        with patch.object(f, 'get_pet') as mock_f_get_pet,\
-                patch.object(f, 'get_food') as mock_f_get_food:
-            ps = PetShop(f)
-            ps.show_pet()
-            self.assertEqual(mock_f_get_pet.call_count, 1)
-            self.assertEqual(mock_f_get_food.call_count, 1)
-
-
-class TestCat(unittest.TestCase):
-
-    @classmethod
-    def setUpClass(cls):
-        cls.c = Cat()
-
-    def test_cat_shall_meow(cls):
-        cls.assertEqual(cls.c.speak(), 'meow')
-
-    def test_cat_shall_be_printable(cls):
-        cls.assertEqual(str(cls.c), 'Cat')
-
-
-class TestDog(unittest.TestCase):
-
-    @classmethod
-    def setUpClass(cls):
-        cls.d = Dog()
-
-    def test_dog_shall_woof(cls):
-        cls.assertEqual(cls.d.speak(), 'woof')
-
-    def test_dog_shall_be_printable(cls):
-        cls.assertEqual(str(cls.d), 'Dog')
-
-
-class PetTest(unittest.TestCase):
-
-    def test_from_name(self):
-        test_cases = [("kitty", "Miao"), ("duck", "Quak")]
-        for name, expected_speech in test_cases:
-            pet = Pet.from_name(name)
-            self.assertEqual(pet.speak(), expected_speech)
+        dog_pet_shop = PetShop(Dog)
+        with patch.object(Dog, 'speak') as mock_Dog_speak:
+            dog_pet_shop.show_pet()
+            self.assertEqual(mock_Dog_speak.call_count, 1)
