Skip to content

Feature (Light Edges / 6) - feat(flags): add --storage-light-edge flag (default false, inert)#4228

Merged
andrejtonev merged 1 commit into
masterfrom
light_edges-06-light-edge-flag
Jun 18, 2026
Merged

Feature (Light Edges / 6) - feat(flags): add --storage-light-edge flag (default false, inert)#4228
andrejtonev merged 1 commit into
masterfrom
light_edges-06-light-edge-flag

Conversation

@andrejtonev

Copy link
Copy Markdown
Contributor

Introduce the opt-in storage_light_edge gflag, its SalientConfig::Items field with back-compat json (de)serialization, and the memgraph.cpp wiring (including the properties_on_edges implication). Default false; no storage code reads the field yet (first reader lands in the light create/find PR), so this is a wholly inert plumbing change that is safe to land mid-stack. A tiny storage_v2_config unit target proves default false, json round-trip, and the missing-key back-compat path.

@andrejtonev andrejtonev added this to the mg-v3.11.0 milestone Jun 3, 2026
@andrejtonev andrejtonev requested a review from as51340 June 3, 2026 06:32
@andrejtonev andrejtonev self-assigned this Jun 3, 2026
@andrejtonev andrejtonev added feature feature Docs needed Docs needed CI -build=community -test=core Run community build and core tests on push CI -build=coverage -test=core Run coverage build and core tests on push CI -build=jepsen -test=core Run jepsen build and core tests on push CI -build=debug -test=core Run debug build and core tests on push CI -build=debug -test=integration Run debug build and integration tests on push CI -build=release -test=e2e Run release build and e2e tests on push CI -build=release -test=stress Run release build and stress tests on push CI -build=release -test=benchmark Run release build and benchmark on push CI -build=release -test=query_modules Run release build and query modules tests on push CI -build=malloc -test=build Run malloc build on push CI -build=coverage -test=clang_tidy CI -build=mage -test=amd labels Jun 3, 2026
@andrejtonev andrejtonev changed the title feat(flags): add --storage-light-edge flag (default false, inert) Feature (Light Edges / 5) - feat(flags): add --storage-light-edge flag (default false, inert) Jun 3, 2026
@andrejtonev andrejtonev changed the title Feature (Light Edges / 5) - feat(flags): add --storage-light-edge flag (default false, inert) Feature (Light Edges / 6) - feat(flags): add --storage-light-edge flag (default false, inert) Jun 3, 2026
@andrejtonev andrejtonev force-pushed the light_edges-06-light-edge-flag branch from f67b220 to c868cff Compare June 3, 2026 10:13
@andrejtonev andrejtonev force-pushed the light_edges-05-edge-pin-guard branch from 6472f56 to 4f86951 Compare June 6, 2026 11:54
@andrejtonev andrejtonev force-pushed the light_edges-06-light-edge-flag branch from c868cff to 5ee790f Compare June 6, 2026 11:54
@andrejtonev andrejtonev force-pushed the light_edges-05-edge-pin-guard branch from 4f86951 to 2b425cf Compare June 6, 2026 20:15
@andrejtonev andrejtonev force-pushed the light_edges-06-light-edge-flag branch from 5ee790f to 6aed92d Compare June 6, 2026 20:15
@andrejtonev andrejtonev force-pushed the light_edges-05-edge-pin-guard branch from 2b425cf to 36f6c51 Compare June 7, 2026 14:07
@andrejtonev andrejtonev force-pushed the light_edges-06-light-edge-flag branch from 6aed92d to 4a3ba31 Compare June 7, 2026 14:07
@andrejtonev andrejtonev force-pushed the light_edges-05-edge-pin-guard branch from 36f6c51 to 8d0c83a Compare June 10, 2026 05:12
@andrejtonev andrejtonev force-pushed the light_edges-06-light-edge-flag branch from 4a3ba31 to 2ef02fa Compare June 10, 2026 05:12
@andrejtonev andrejtonev marked this pull request as ready for review June 11, 2026 09:54
@andrejtonev andrejtonev modified the milestones: mg-v3.11.0, mg-v3.12.0 Jun 15, 2026
@andrejtonev andrejtonev force-pushed the light_edges-06-light-edge-flag branch from 2ef02fa to c882b1c Compare June 15, 2026 12:24
@andrejtonev andrejtonev force-pushed the light_edges-05-edge-pin-guard branch 2 times, most recently from 64b1630 to dd7eadc Compare June 18, 2026 07:13
Base automatically changed from light_edges-05-edge-pin-guard to master June 18, 2026 08:48
@andrejtonev andrejtonev removed CI -build=community -test=core Run community build and core tests on push CI -build=coverage -test=core Run coverage build and core tests on push CI -build=jepsen -test=core Run jepsen build and core tests on push CI -build=debug -test=core Run debug build and core tests on push CI -build=debug -test=integration Run debug build and integration tests on push CI -build=release -test=e2e Run release build and e2e tests on push CI -build=release -test=stress Run release build and stress tests on push CI -build=release -test=benchmark Run release build and benchmark on push CI -build=release -test=query_modules Run release build and query modules tests on push CI -build=malloc -test=build Run malloc build on push CI -build=coverage -test=clang_tidy CI -build=mage -test=amd labels Jun 18, 2026
Introduce the opt-in storage_light_edge gflag, its SalientConfig::Items
field with back-compat json (de)serialization, and the memgraph.cpp
wiring (including the properties_on_edges implication). Default false;
no storage code reads the field yet (first reader lands in the light
create/find PR), so this is a wholly inert plumbing change that is safe
to land mid-stack. A tiny storage_v2_config unit target proves default
false, json round-trip, and the missing-key back-compat path.
@andrejtonev andrejtonev force-pushed the light_edges-06-light-edge-flag branch from c882b1c to d0af0ad Compare June 18, 2026 09:22
@andrejtonev andrejtonev enabled auto-merge June 18, 2026 09:22
@andrejtonev andrejtonev added this pull request to the merge queue Jun 18, 2026
@sonarqubecloud

Copy link
Copy Markdown

Merged via the queue into master with commit c88cf49 Jun 18, 2026
38 checks passed
@andrejtonev andrejtonev deleted the light_edges-06-light-edge-flag branch June 18, 2026 10:49
@andrejtonev andrejtonev added Docs unnecessary Docs unnecessary and removed Docs needed Docs needed labels Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Docs unnecessary Docs unnecessary feature feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants