Handle reasons that are None.

jcgregorio · jcgregorio · commit e7bbbb94d070 · 2013-02-20T15:37:24.000-05:00
Reviewed in https://codereview.appspot.com/7396043/.
diff --git a/apiclient/errors.py b/apiclient/errors.py
@@ -49,6 +49,8 @@ def _get_reason(self):
       reason = data['error']['message']
     except (ValueError, KeyError):
       pass
+    if reason is None:
+      reason = ''
     return reason
 
   def __repr__(self):
diff --git a/tests/test_errors.py b/tests/test_errors.py
@@ -91,3 +91,9 @@ def test_non_json(self):
     resp, content = fake_response('}NOT OK', {'status':'400'})
     error = HttpError(resp, content)
     self.assertEqual(str(error), '<HttpError 400 "Ok">')
+
+  def test_missing_reason(self):
+    """Test an empty dict with a missing resp.reason."""
+    resp, content = fake_response('}NOT OK', {'status':'400'}, reason=None)
+    error = HttpError(resp, content)
+    self.assertEqual(str(error), '<HttpError 400 "">')
